public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Alan Cox <alan@lxorguk.ukuu.org.uk>
To: Jeff Garzik <jeff@garzik.org>
Cc: Andrew Morton <akpm@osdl.org>,
	LKML <linux-kernel@vger.kernel.org>, Greg KH <greg@kroah.com>,
	Linus Torvalds <torvalds@osdl.org>
Subject: Re: [PATCH] device_for_each_child(): kill pointless warning noise
Date: Thu, 28 Sep 2006 12:30:30 +0100	[thread overview]
Message-ID: <1159443030.11049.409.camel@localhost.localdomain> (raw)
In-Reply-To: <451B2A58.9010603@garzik.org>

Ar Mer, 2006-09-27 am 21:50 -0400, ysgrifennodd Jeff Garzik:
> "almost all"  Thus it is wrong to _force_ the usage model on the caller.
> 
> It should be obvious that a simple search need not _require_ a dummy 
> return value, that is promptly ignored.

How about just adding an explicit device_for_each_child_noret() or
similar function so that the safety check stays as well for the usual
case.

Alan

      reply	other threads:[~2006-09-28 11:05 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-09-28  1:05 [PATCH] device_for_each_child(): kill pointless warning noise Jeff Garzik
2006-09-28  1:42 ` Andrew Morton
2006-09-28  1:50   ` Jeff Garzik
2006-09-28 11:30     ` Alan Cox [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1159443030.11049.409.camel@localhost.localdomain \
    --to=alan@lxorguk.ukuu.org.uk \
    --cc=akpm@osdl.org \
    --cc=greg@kroah.com \
    --cc=jeff@garzik.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=torvalds@osdl.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox