[PATCH] rtc driver rtc-pcf8563 century bit inversed

Jean-Baptiste Maneyrol
2006-09-28T14:20:10Z

[-- Attachment #1: Type: text/plain, Size: 292 bytes --]

The century bit PCF8563_MO_C in the month register is misinterpreted. It
is set to 1 for the 20th century and 0 for 21th, and the driver is
expecting the opposite behavior.

Here is a small patch to address this issue.
Thanks for all the good work!

Jean-Baptiste Maneyrol
Teamlog - France

[-- Attachment #2: patch --]
[-- Type: text/plain, Size: 796 bytes --]

--- linux-2.6.18/drivers/rtc/rtc-pcf8563.c 2006-09-20 05:42:06.000000000 +0200
+++ linux-2.6.18_tlgate/drivers/rtc/rtc-pcf8563.c 2006-09-28 15:59:28.000000000 +0200
@@ -95,7 +95,7 @@
tm->tm_wday = buf[PCF8563_REG_DW] & 0x07;
tm->tm_mon = BCD2BIN(buf[PCF8563_REG_MO] & 0x1F) - 1; /* rtc mn 1-12 */
tm->tm_year = BCD2BIN(buf[PCF8563_REG_YR])
- + (buf[PCF8563_REG_MO] & PCF8563_MO_C ? 100 : 0);
+ + (buf[PCF8563_REG_MO] & PCF8563_MO_C ? 0 : 100);

dev_dbg(&client->dev, "%s: tm is secs=%d, mins=%d, hours=%d, "
"mday=%d, mon=%d, year=%d, wday=%d\n",
@@ -135,7 +135,7 @@

/* year and century */
buf[PCF8563_REG_YR] = BIN2BCD(tm->tm_year % 100);
- if (tm->tm_year / 100)
+ if (tm->tm_year < 100)
buf[PCF8563_REG_MO] |= PCF8563_MO_C;

buf[PCF8563_REG_DW] = tm->tm_wday & 0x07;