From: Benjamin Herrenschmidt <benh@kernel.crashing.org>
To: Mel Gorman <mel@csn.ul.ie>
Cc: Judith Lebzelter <judith@osdl.org>,
linux-kernel@vger.kernel.org, akpm@osdl.org,
Paul Mackerras <paulus@samba.org>
Subject: Re: 2.6.18-rc6-mm2: fix for error compiling ppc/mm/init.c
Date: Tue, 03 Oct 2006 22:12:32 +1000 [thread overview]
Message-ID: <1159877552.5482.69.camel@localhost.localdomain> (raw)
In-Reply-To: <Pine.LNX.4.64.0610031023100.13141@skynet.skynet.ie>
> Once we have a patch using symbolic names working on ppc, I'll make a
> patch that uses symbolic names on the other architectures and post it.
Ok, good :) I don't like magic numbers
> I don't know if it has been fixed either.
Yeah... I'm not in a mood to audit all of that for 2.6.19, so I'd rather
keep it the way it is for now.
> Once we get ppc sorted, I'll make a patch that uses explicit array
> initialisation and symbolic index names on the other arches.
Ok. Any reason why my current patch wouldn't be good then ? If it's ok
for you, I'll put it in paulus queue for merging.
> I believe it was to stop having more empty zones than was really
> necessary. It was a saving on NUMA. I might be wrong, I'll need to check
> the archives again.
Well, as long as we use named indices in the array and make sure it's
properly initialized to 0, that should be ok.
> You're right. The generic code does handle this case because at one point,
> I remembered clearly that not all zones would be in use :/
Good then :)
Cheers,
Ben.
next prev parent reply other threads:[~2006-10-03 12:13 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-09-14 17:37 2.6.18-rc6-mm2: fix for error compiling ppc/mm/init.c Judith Lebzelter
2006-09-14 18:11 ` Mel Gorman
2006-10-03 4:24 ` Benjamin Herrenschmidt
2006-10-03 8:51 ` Mel Gorman
2006-10-03 9:19 ` Benjamin Herrenschmidt
2006-10-03 9:34 ` Mel Gorman
2006-10-03 12:12 ` Benjamin Herrenschmidt [this message]
2006-10-03 13:04 ` Mel Gorman
2006-10-04 3:22 ` Benjamin Herrenschmidt
2006-10-04 14:12 ` Mel Gorman
2006-10-05 9:09 ` Benjamin Herrenschmidt
2006-10-09 23:25 ` Paul Mackerras
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1159877552.5482.69.camel@localhost.localdomain \
--to=benh@kernel.crashing.org \
--cc=akpm@osdl.org \
--cc=judith@osdl.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mel@csn.ul.ie \
--cc=paulus@samba.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox