* [Patch] Remove unnecessary check in fs/fat/inode.c
@ 2006-10-04 16:23 Eric Sesterhenn
2006-10-04 16:36 ` OGAWA Hirofumi
0 siblings, 1 reply; 2+ messages in thread
From: Eric Sesterhenn @ 2006-10-04 16:23 UTC (permalink / raw)
To: linux-kernel; +Cc: hirofumi
hi,
since all callers dereference sb, and this function
does so earlier too, we dont need the check.
Signed-off-by: Eric Sesterhenn <snakebyte@gmx.de>
--- linux-2.6.18-git21/fs/fat/inode.c.orig 2006-10-04 18:21:03.000000000 +0200
+++ linux-2.6.18-git21/fs/fat/inode.c 2006-10-04 18:21:22.000000000 +0200
@@ -1472,7 +1472,7 @@ int fat_flush_inodes(struct super_block
ret = writeback_inode(i1);
if (!ret && i2)
ret = writeback_inode(i2);
- if (!ret && sb) {
+ if (!ret) {
struct address_space *mapping = sb->s_bdev->bd_inode->i_mapping;
ret = filemap_flush(mapping);
}
^ permalink raw reply [flat|nested] 2+ messages in thread* Re: [Patch] Remove unnecessary check in fs/fat/inode.c
2006-10-04 16:23 [Patch] Remove unnecessary check in fs/fat/inode.c Eric Sesterhenn
@ 2006-10-04 16:36 ` OGAWA Hirofumi
0 siblings, 0 replies; 2+ messages in thread
From: OGAWA Hirofumi @ 2006-10-04 16:36 UTC (permalink / raw)
To: Eric Sesterhenn; +Cc: linux-kernel, Andrew Morton
Eric Sesterhenn <snakebyte@gmx.de> writes:
> since all callers dereference sb, and this function
> does so earlier too, we dont need the check.
>
> Signed-off-by: Eric Sesterhenn <snakebyte@gmx.de>
>
> --- linux-2.6.18-git21/fs/fat/inode.c.orig 2006-10-04 18:21:03.000000000 +0200
> +++ linux-2.6.18-git21/fs/fat/inode.c 2006-10-04 18:21:22.000000000 +0200
> @@ -1472,7 +1472,7 @@ int fat_flush_inodes(struct super_block
> ret = writeback_inode(i1);
> if (!ret && i2)
> ret = writeback_inode(i2);
> - if (!ret && sb) {
> + if (!ret) {
> struct address_space *mapping = sb->s_bdev->bd_inode->i_mapping;
> ret = filemap_flush(mapping);
> }
Acked-by: OGAWA Hirofumi <hirofumi@mail.parknet.co.jp>
Thanks.
--
OGAWA Hirofumi <hirofumi@mail.parknet.co.jp>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2006-10-04 16:36 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2006-10-04 16:23 [Patch] Remove unnecessary check in fs/fat/inode.c Eric Sesterhenn
2006-10-04 16:36 ` OGAWA Hirofumi
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox