From: keith mannthey <kmannth@us.ibm.com>
To: Jiri Kosina <jikos@jikos.cz>
Cc: lkml <linux-kernel@vger.kernel.org>, Linus Torvalds <torvalds@osdl.org>
Subject: Re: [PATCH] make mach-generic/summit.c compile on UP
Date: Thu, 05 Oct 2006 13:31:32 -0700 [thread overview]
Message-ID: <1160080292.5664.9.camel@keithlap> (raw)
In-Reply-To: <Pine.LNX.4.64.0610051913010.12556@twin.jikos.cz>
On Thu, 2006-10-05 at 19:16 +0200, Jiri Kosina wrote:
> Hi,
>
> arch/i386/mach-generic/summit.c doesn't compile (neither in current
> mainline git tree, nor in 2.6.18-mm3) when CONFIG_SMP is not set:
>
> In file included from arch/i386/mach-generic/summit.c:17:
> include/asm/mach-summit/mach_apic.h: In function 'apicid_to_node':
> include/asm/mach-summit/mach_apic.h:91: error: 'apicid_2_node' undeclared (first use in this function)
> include/asm/mach-summit/mach_apic.h:91: error: (Each undeclared identifier is reported only once
> include/asm/mach-summit/mach_apic.h:91: error: for each function it appears in.)
> Is the patch below correct?
Well I guess it would fix the apicid_2_node build error but I can't
think of a single good reason to be in a config where you would need any
of the summit code in UP. Perhaps a kconfig or makefile change in the
right spot would be better.
Can you send along your config file so I can better understand? I seem
to be able to build i386 UP just fine.
Thanks,
Keith
next prev parent reply other threads:[~2006-10-05 20:31 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-10-05 17:16 [PATCH] make mach-generic/summit.c compile on UP Jiri Kosina
2006-10-05 20:31 ` keith mannthey [this message]
2006-10-05 21:18 ` Jiri Kosina
2006-10-05 22:24 ` keith mannthey
2006-10-06 9:11 ` Jiri Kosina
2006-10-06 17:23 ` keith mannthey
2006-10-05 23:11 ` Andi Kleen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1160080292.5664.9.camel@keithlap \
--to=kmannth@us.ibm.com \
--cc=jikos@jikos.cz \
--cc=linux-kernel@vger.kernel.org \
--cc=torvalds@osdl.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox