[PATCH] [PATCH] Rename pdc_init

[PATCH] [PATCH] Rename pdc_init

[Matthew Wilcox]

parisc uses pdc_init() for different purposes, so call it pdc202xx_init
instead.

Signed-off-by: Matthew Wilcox <matthew@wil.cx>
---
 drivers/ata/pata_pdc202xx_old.c |    8 ++++----
 1 files changed, 4 insertions(+), 4 deletions(-)

diff --git a/drivers/ata/pata_pdc202xx_old.c b/drivers/ata/pata_pdc202xx_old.c
index 5ba9eb2..8850ed5 100644
--- a/drivers/ata/pata_pdc202xx_old.c
+++ b/drivers/ata/pata_pdc202xx_old.c
@@ -402,12 +402,12 @@ static struct pci_driver pdc_pci_driver 
 	.remove		= ata_pci_remove_one
 };
 
-static int __init pdc_init(void)
+static int __init pdc202xx_init(void)
 {
 	return pci_register_driver(&pdc_pci_driver);
 }
 
-static void __exit pdc_exit(void)
+static void __exit pdc202xx_exit(void)
 {
 	pci_unregister_driver(&pdc_pci_driver);
 }
@@ -418,5 +418,5 @@ MODULE_LICENSE("GPL");
 MODULE_DEVICE_TABLE(pci, pdc);
 MODULE_VERSION(DRV_VERSION);
 
-module_init(pdc_init);
-module_exit(pdc_exit);
+module_init(pdc202xx_init);
+module_exit(pdc202xx_exit);
-- 
1.4.1.1

Re: [PATCH] [PATCH] Rename pdc_init

[Jeff Garzik]

Matthew Wilcox wrote:
> parisc uses pdc_init() for different purposes, so call it pdc202xx_init
> instead.
> 
> Signed-off-by: Matthew Wilcox <matthew@wil.cx>

I don't mind the patch (you should have CC'd me and linux-ide though), 
but where is parisc's pdc_init actually used, and why is it global?

	Jeff

Re: [PATCH] [PATCH] Rename pdc_init

[Matthew Wilcox]

On Fri, Oct 06, 2006 at 12:42:18PM -0400, Jeff Garzik wrote:
> I don't mind the patch (you should have CC'd me and linux-ide though), 

We really need to figure out how to communicate that better.  I just
sent it to the maintainer (as listed in MODULE_AUTHOR).  Do we need a
MODULE_CHANGES_CC macro too?

> but where is parisc's pdc_init actually used, and why is it global?

Hmm.  Embarrassing.  Seems it's a stale prototype; I'll delete it.

OTOH, there is a pdc_init in avr32, and it's prudent to not have two
functions of the same name, so that you know which one is appearing in a
backtrace.  So it might be a good idea to apply this patch anyway.

Re: [PATCH] [PATCH] Rename pdc_init

[Alan Cox]

Ar Gwe, 2006-10-06 am 12:42 -0400, ysgrifennodd Jeff Garzik:
> Matthew Wilcox wrote:
> > parisc uses pdc_init() for different purposes, so call it pdc202xx_init
> > instead.
> > 
> > Signed-off-by: Matthew Wilcox <matthew@wil.cx>
> 
> I don't mind the patch (you should have CC'd me and linux-ide though), 
> but where is parisc's pdc_init actually used, and why is it global?

Can you cc me the patch as well ?

Re: [PATCH] [PATCH] Rename pdc_init

[Matthew Wilcox]

On Fri, Oct 06, 2006 at 06:30:21PM +0100, Alan Cox wrote:
> Ar Gwe, 2006-10-06 am 12:42 -0400, ysgrifennodd Jeff Garzik:
> > Matthew Wilcox wrote:
> > > parisc uses pdc_init() for different purposes, so call it pdc202xx_init
> > > instead.
> > > 
> > > Signed-off-by: Matthew Wilcox <matthew@wil.cx>
> > 
> > I don't mind the patch (you should have CC'd me and linux-ide though), 
> > but where is parisc's pdc_init actually used, and why is it global?
> 
> Can you cc me the patch as well ?

Um, I did.  Did your spamfilter eat it?

From: Matthew Wilcox <matthew@wil.cx>
To: Alan Cox <alan@lxorguk.ukuu.org.uk>
Cc: linux-kernel@vger.kernel.org, Matthew Wilcox <matthew@wil.cx>

Re: [PATCH] [PATCH] Rename pdc_init

[Alan Cox]

Ar Gwe, 2006-10-06 am 11:07 -0600, ysgrifennodd Matthew Wilcox:
> > Can you cc me the patch as well ?
> 
> Um, I did.  Did your spamfilter eat it?

Ah found it, no my filters filed it under parisc 8)

"NAK" to the patch as is because the other drivers for consistency use
the same prefix for all functions for the same chip. I will however add
a TODO note to myself to rename them all properly next time I work on
that driver.

Alan