From: "Frédéric Riss" <frederic.riss@gmail.com>
To: Linus Torvalds <torvalds@osdl.org>
Cc: Arjan van de Ven <arjan@infradead.org>,
Pavel Machek <pavel@ucw.cz>,
Linux Kernel list <linux-kernel@vger.kernel.org>,
len.brown@intel.com
Subject: Re: 2.6.18 suspend regression on Intel Macs
Date: Tue, 10 Oct 2006 21:08:15 +0200 [thread overview]
Message-ID: <1160507296.5134.4.camel@funkylaptop> (raw)
In-Reply-To: <Pine.LNX.4.64.0610100830370.3952@g5.osdl.org>
Le mardi 10 octobre 2006 à 08:33 -0700, Linus Torvalds a écrit :
> > If we do this we probably should at least key this of some DMI
> > identification for the mac mini..
>
> No. That would be silly.
>
> Having _conditional_ code is not only bigger, it's orders of magnitude
> more complex and likely to break. It's much better to say: "We know at
> least one machine needs this" than it is to say "We know machine X needs
> this", because the latter has extra complexity that just doesn't buy you
> anything.
>
> It's much better to treat everybody the same, if that works. That way, you
> don't have different code-paths.
So what's the plan? Should/Will the ACPI guys remove the bit-preserving
change brought in with the latest ACPICA merge?
Fred.
next prev parent reply other threads:[~2006-10-10 19:08 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-10-09 18:19 2.6.18 suspend regression on Intel Macs Frédéric Riss
2006-10-10 10:39 ` Pavel Machek
2006-10-10 10:41 ` Arjan van de Ven
2006-10-10 10:49 ` Pavel Machek
2006-10-10 15:33 ` Linus Torvalds
2006-10-10 19:08 ` Frédéric Riss [this message]
2006-10-10 19:38 ` Arjan van de Ven
2006-10-10 19:46 ` Frédéric Riss
2006-10-10 19:50 ` Pavel Machek
2006-10-10 21:49 ` Linus Torvalds
2006-10-10 22:09 ` Frédéric Riss
2006-10-10 23:53 ` Linus Torvalds
2006-10-11 6:09 ` Frédéric Riss
2006-10-11 13:16 ` suspend debugging " Pavel Machek
2006-10-11 6:35 ` Len Brown
2006-10-11 14:35 ` Linus Torvalds
2006-10-10 21:28 ` Matthew Garrett
2006-10-11 6:37 ` Len Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1160507296.5134.4.camel@funkylaptop \
--to=frederic.riss@gmail.com \
--cc=arjan@infradead.org \
--cc=len.brown@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=pavel@ucw.cz \
--cc=torvalds@osdl.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox