public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Sergio Monteiro Basto <sergio@sergiomb.no-ip.org>
To: Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: [PATCH] take #1 report_lost_ticks boot parameter should be default
Date: Thu, 12 Oct 2006 02:58:49 +0100	[thread overview]
Message-ID: <1160618330.8766.24.camel@localhost.portugal> (raw)

[-- Attachment #1: Type: text/plain, Size: 2378 bytes --]

Hi,
After begin testing next patches for 2.4.19.  
I tried the 2.6.18-mm3 and I tried boot up with acpi=noirq (which is the
same of pci=noacpi), and boots fine without any warning.
And it was a nightmare on stress testings of this two days. At begging I
don't understand why, but after a while I try remember report_lost_ticks
and nightmare ends. The boot parameter reports lost ticket everywhere,
because I (still) need boot up with "notsc".
I believe that it not just my computer that suffer this problem and with
report_lost_ticks by default, we understand quickly that we need boot
with "notsc" or something else. For computer don't crash on a little
stress. Like play a avi movie with mplyer and copy over Ethernet some
others files.
 
Something like this : 
diff ./x86_64/kernel/time.c.orig ./x86_64/kernel/time.c -up
--- ./x86_64/kernel/time.c.orig 2006-10-12 02:50:41.000000000 +0100
+++ ./x86_64/kernel/time.c      2006-10-12 02:54:52.000000000 +0100
@@ -71,7 +71,7 @@ static unsigned long hpet_period;                     /* f
 unsigned long hpet_tick;                               /* HPET clocks / interrupt */
 int hpet_use_timer;                            /* Use counter of hpet for time keeping, otherwise PIT */
 unsigned long vxtime_hz = PIT_TICK_RATE;
-int report_lost_ticks;                         /* command line option */
+int noreport_lost_ticks;                               /* command line option */
 unsigned long long monotonic_base;

 struct vxtime_data __vxtime __section_vxtime;  /* for vsyscalls */
@@ -316,7 +316,7 @@ static noinline void handle_lost_ticks(i
 {
        static long lost_count;
        static int warned;
-       if (report_lost_ticks) {
+       if (!noreport_lost_ticks) {
                printk(KERN_WARNING "time.c: Lost %d timer tick(s)! ", lost);
                print_symbol("rip %s)\n", regs->rip);
        }
@@ -885,7 +885,7 @@ void __init stop_timer_interrupt(void)

 int __init time_setup(char *str)
 {
-       report_lost_ticks = 1;
+       noreport_lost_ticks = 1;
        return 1;
 }

@@ -1004,7 +1004,7 @@ __init static char *time_init_gtod(void)
        return timetype;
 }

-__setup("report_lost_ticks", time_setup);
+__setup("noreport_lost_ticks", time_setup);

 static long clock_cmos_diff;
 static unsigned long sleep_start;

Thanks,
-- 
Sérgio M.B.

[-- Attachment #2: smime.p7s --]
[-- Type: application/x-pkcs7-signature, Size: 2166 bytes --]

                 reply	other threads:[~2006-10-12  1:58 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1160618330.8766.24.camel@localhost.portugal \
    --to=sergio@sergiomb.no-ip.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox