From: Mike Galbraith <efault@gmx.de>
To: Jens Axboe <jens.axboe@oracle.com>
Cc: Alex Romosan <romosan@sycorax.lbl.gov>,
linux-kernel@vger.kernel.org, olaf@aepfle.de
Subject: Re: 2.6.19-rc1 regression: unable to read dvd's
Date: Thu, 12 Oct 2006 14:44:50 +0000 [thread overview]
Message-ID: <1160664290.6207.2.camel@Homer.simpson.net> (raw)
In-Reply-To: <20061012122146.GS6515@kernel.dk>
On Thu, 2006-10-12 at 14:21 +0200, Jens Axboe wrote:
> Mike/Alex/Olaf, can you give this a spin? Totally untested here, but I
> think it should fix it.
Yup, all better here. Thanks.
-Mike
> diff --git a/drivers/ide/ide-cd.c b/drivers/ide/ide-cd.c
> index 69bbb62..e7513e5 100644
> --- a/drivers/ide/ide-cd.c
> +++ b/drivers/ide/ide-cd.c
> @@ -597,7 +597,7 @@ static void cdrom_prepare_request(ide_dr
> struct cdrom_info *cd = drive->driver_data;
>
> ide_init_drive_cmd(rq);
> - rq->cmd_type = REQ_TYPE_BLOCK_PC;
> + rq->cmd_type = REQ_TYPE_ATA_PC;
> rq->rq_disk = cd->disk;
> }
>
> @@ -2023,7 +2023,8 @@ ide_do_rw_cdrom (ide_drive_t *drive, str
> }
> info->last_block = block;
> return action;
> - } else if (rq->cmd_type == REQ_TYPE_SENSE) {
> + } else if (rq->cmd_type == REQ_TYPE_SENSE ||
> + rq->cmd_type == REQ_TYPE_ATA_PC) {
> return cdrom_do_packet_command(drive);
> } else if (blk_pc_request(rq)) {
> return cdrom_do_block_pc(drive, rq);
> diff --git a/include/linux/blkdev.h b/include/linux/blkdev.h
> index 26f7856..d370d2c 100644
> --- a/include/linux/blkdev.h
> +++ b/include/linux/blkdev.h
> @@ -157,6 +157,7 @@ enum rq_cmd_type_bits {
> REQ_TYPE_ATA_CMD,
> REQ_TYPE_ATA_TASK,
> REQ_TYPE_ATA_TASKFILE,
> + REQ_TYPE_ATA_PC,
> };
>
> /*
>
next prev parent reply other threads:[~2006-10-12 12:38 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-10-12 1:45 2.6.19-rc1 regression: unable to read dvd's Alex Romosan
2006-10-12 6:53 ` Jens Axboe
2006-10-12 10:28 ` Mike Galbraith
2006-10-12 14:13 ` Mike Galbraith
2006-10-12 12:09 ` Jens Axboe
2006-10-12 12:21 ` Jens Axboe
2006-10-12 14:44 ` Mike Galbraith [this message]
2006-10-12 13:07 ` Jens Axboe
2006-10-12 15:19 ` Alex Romosan
2006-10-12 15:23 ` Jens Axboe
2006-10-12 15:47 ` Alex Romosan
2006-10-12 19:00 ` Mike Galbraith
2006-10-12 17:02 ` Alex Romosan
2006-10-12 18:05 ` Jens Axboe
2006-10-12 16:04 ` Alex Romosan
2006-10-12 16:51 ` Jens Axboe
2006-10-13 14:40 ` 2.6.19-rc1 (+ide-cd patches) regression: unable to rip cd Alex Romosan
2006-10-12 19:28 ` 2.6.19-rc1 regression: unable to read dvd's Olaf Hering
2006-10-12 20:20 ` Jens Axboe
2006-10-12 14:31 ` Mike Galbraith
2006-10-12 10:55 ` Alan Cox
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1160664290.6207.2.camel@Homer.simpson.net \
--to=efault@gmx.de \
--cc=jens.axboe@oracle.com \
--cc=linux-kernel@vger.kernel.org \
--cc=olaf@aepfle.de \
--cc=romosan@sycorax.lbl.gov \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox