From: Alan Cox <alan@lxorguk.ukuu.org.uk>
To: Amol Lad <amol@verismonetworks.com>
Cc: linux kernel <linux-kernel@vger.kernel.org>,
kernel Janitors <kernel-janitors@lists.osdl.org>
Subject: Re: [PATCH] drivers/char/riscom8.c: save_flags()/cli()/sti() removal
Date: Sat, 14 Oct 2006 15:20:02 +0100 [thread overview]
Message-ID: <1160835602.5732.30.camel@localhost.localdomain> (raw)
In-Reply-To: <1160739628.19143.376.camel@amol.verismonetworks.com>
Ar Gwe, 2006-10-13 am 17:10 +0530, ysgrifennodd Amol Lad:
> Removed save_flags()/cli()/sti() and used (light weight) spin locks
>
Three things I see that look problematic
1. The irq locking isn't doing anything as the IRQ handler itself is not
taking the lock
2. If the irq handler itself dumbly locks to fix this then we get
tty_flip_buffer_push() re-entering the other code paths and deadlocking
if low latency is enabled
3. Some of the use of local_save/spin_lock_irq seems over-clever and
unneeded
Fixable but how about we just delete the file since it has been broken
for ages and nobody can be using it ?
next prev parent reply other threads:[~2006-10-14 13:53 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-10-13 11:40 [PATCH] drivers/char/riscom8.c: save_flags()/cli()/sti() removal Amol Lad
2006-10-13 11:56 ` Arjan van de Ven
2006-10-13 12:36 ` Amol Lad
2006-10-13 15:00 ` Alan Cox
2006-10-14 7:39 ` Amol Lad
2006-10-14 12:18 ` Alan Cox
2006-10-14 14:20 ` Alan Cox [this message]
2006-10-14 17:49 ` [KJ] " Matthew Wilcox
2006-10-14 18:41 ` Alan Cox
2006-10-14 18:50 ` Matthew Wilcox
2006-10-16 4:32 ` Amol Lad
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1160835602.5732.30.camel@localhost.localdomain \
--to=alan@lxorguk.ukuu.org.uk \
--cc=amol@verismonetworks.com \
--cc=kernel-janitors@lists.osdl.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox