From: Alan Cox <alan@lxorguk.ukuu.org.uk>
To: Jiri Slaby <jirislaby@gmail.com>
Cc: Andrew Morton <akpm@osdl.org>,
linux-kernel@vger.kernel.org, R.E.Wolff@BitWizard.nl,
Amit Gud <gud@eth.net>, Greg Kroah-Hartman <gregkh@suse.de>
Subject: Re: [PATCH 1/1] Char: correct pci_get_device changes
Date: Sun, 15 Oct 2006 01:20:01 +0100 [thread overview]
Message-ID: <1160871601.5732.49.camel@localhost.localdomain> (raw)
In-Reply-To: <1966866271061818079@wsc.cz>
Ar Sul, 2006-10-15 am 01:36 +0200, ysgrifennodd Jiri Slaby:
> correct pci_get_device changes
>
> Commits 881a8c120acf7ec09c90289e2996b7c70f51e996 and
> efe1ec27837d6639eae82e1f5876910ba6433c3f are totally wrong and
No I disagree, they are totally right. They stop crashes walking the
list during a hotplug of another card. If you hotplug the moxa or rio
card you are screwed. Your patches solve a different problem to the ones
the pci_dev_get changes solve.
Your changes also minimally handle the hotplug of the moxa or rio card
which I guess could theoretically happen in some weird system and are a
definite improvement.
> It affects moxa and rio char drivers. (All this stuff deserves to be
> converted to pci_probing, though.)
Agreed, or dropped
Acked-by: Alan Cox <alan@redhat.com>
next prev parent reply other threads:[~2006-10-14 23:54 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-10-14 23:36 [PATCH 1/1] Char: correct pci_get_device changes Jiri Slaby
2006-10-15 0:20 ` Alan Cox [this message]
2006-10-15 3:52 ` Greg KH
2006-10-16 22:36 ` Andrew Morton
2006-10-16 22:38 ` Jiri Slaby
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1160871601.5732.49.camel@localhost.localdomain \
--to=alan@lxorguk.ukuu.org.uk \
--cc=R.E.Wolff@BitWizard.nl \
--cc=akpm@osdl.org \
--cc=gregkh@suse.de \
--cc=gud@eth.net \
--cc=jirislaby@gmail.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox