From: Mauro Carvalho Chehab <mchehab@infradead.org>
To: Manu Abraham <abraham.manu@gmail.com>
Cc: Florin Malita <fmalita@gmail.com>,
Trent Piepho <xyzzy@speakeasy.org>,
v4l-dvb maintainer list <v4l-dvb-maintainer@linuxtv.org>,
linux-kernel@vger.kernel.org
Subject: Re: [v4l-dvb-maintainer] [PATCH] V4L/DVB: potential leak in dvb-bt8xx
Date: Sun, 15 Oct 2006 14:18:35 -0300 [thread overview]
Message-ID: <1160932715.5364.1.camel@praia> (raw)
In-Reply-To: <45326359.4000502@gmail.com>
Em Dom, 2006-10-15 às 20:35 +0400, Manu Abraham escreveu:
> Florin Malita wrote:
> > Trent Piepho wrote:
> >> I believe that 'state' will be kfree'd by the dst_attach() function if there
> >> is a failure. Not what you would expect, to have it allocated in the bt8xx
> >> driver (why do is there??) and freed on error in a different function.
> >>
> >
> > Hm, you're right - it is kfreed in dst_attach(). But we're still missing
> > the kmalloc result check...
> >
>
> This patch was applied a few days back
Yes.
It is at:
http://www.kernel.org/git/?p=linux/kernel/git/mchehab/v4l-dvb.git;a=commit;h=626ae83bb24927ca015503448f0199842ae2e8da
I've already asked Linus to pull it, together with other 17 fixes, to
Mainstream.
>
> Manu
Cheers,
Mauro.
next prev parent reply other threads:[~2006-10-15 17:19 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-10-14 17:39 [PATCH] V4L/DVB: potential leak in dvb-bt8xx Florin Malita
2006-10-15 0:33 ` [v4l-dvb-maintainer] " Trent Piepho
2006-10-15 16:02 ` Florin Malita
2006-10-15 16:35 ` Manu Abraham
2006-10-15 17:18 ` Mauro Carvalho Chehab [this message]
2006-10-15 17:39 ` Manu Abraham
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1160932715.5364.1.camel@praia \
--to=mchehab@infradead.org \
--cc=abraham.manu@gmail.com \
--cc=fmalita@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=v4l-dvb-maintainer@linuxtv.org \
--cc=xyzzy@speakeasy.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox