From: Alan Cox <alan@lxorguk.ukuu.org.uk>
To: ggaleotti@interfree.it
Cc: akpm@osdl.org, wim@iguana.be, linux-kernel@vger.kernel.org
Subject: Re: [patch 1/1] watchdog driver for Digital-Logic MSM-P5XEN PC104 unit
Date: Tue, 17 Oct 2006 14:38:36 +0100 [thread overview]
Message-ID: <1161092316.24237.169.camel@localhost.localdomain> (raw)
In-Reply-To: <20061017123440.4321.qmail@community1.interfree.it>
Ar Maw, 2006-10-17 am 12:34 +0000, ysgrifennodd ggaleotti@interfree.it:
> +static void
> +wdt_enable(unsigned long data)
> +{
> + (void)data;
> +
> + outb(inb(io_base + WDT_OFFSET) & 0xf7, io_base + WDT_OFFSET);
> +}
> +
If you don't need "data" why pass it ?
No locking against parallel close/open
No no-way-out lock implementation
Short many of the standard ioctls it could and should implement (eg
timeout get)
NAK for now although it just needs tidying and expanding out a little to
be a good driver.
next prev parent reply other threads:[~2006-10-17 13:11 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-10-17 12:34 [patch 1/1] watchdog driver for Digital-Logic MSM-P5XEN PC104 unit ggaleotti
2006-10-17 13:38 ` Alan Cox [this message]
2006-10-17 23:31 ` Andrew Morton
2006-11-01 19:52 ` Wim Van Sebroeck
2006-11-01 21:40 ` Wim Van Sebroeck
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1161092316.24237.169.camel@localhost.localdomain \
--to=alan@lxorguk.ukuu.org.uk \
--cc=akpm@osdl.org \
--cc=ggaleotti@interfree.it \
--cc=linux-kernel@vger.kernel.org \
--cc=wim@iguana.be \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox