Re: + i386-time-avoid-pit-smp-lockups.patch added to -mm tree

[john stultz <johnstul@us.ibm.com>]

On Thu, 2006-10-19 at 06:44 -0700, Daniel Walker wrote:
> On Wed, 2006-10-11 at 14:26 -0700, akpm@osdl.org wrote:
> 
> > diff -puN arch/i386/kernel/i8253.c~i386-time-avoid-pit-smp-lockups arch/i386/kernel/i8253.c
> > --- a/arch/i386/kernel/i8253.c~i386-time-avoid-pit-smp-lockups
> > +++ a/arch/i386/kernel/i8253.c
> > @@ -109,7 +109,7 @@ static struct clocksource clocksource_pi
> >  
> >  static int __init init_pit_clocksource(void)
> >  {
> > -	if (num_possible_cpus() > 4) /* PIT does not scale! */
> > +	if (num_possible_cpus() > 1) /* PIT does not scale! */
> >  		return 0;
> >  
> 
> Can we ifdef some code here on CONFIG_SMP . It bugs me that there just
> dead code laying around on smp systems.

I still want the pit to be available on SMP kernels that boot on UP
systems, so I don't think an ifdef will do it. Maybe it would be
possible to do some smp alternatives-like code removal on SMP systems?

thanks
-john