From: Will Schmidt <will_schmidt@vnet.ibm.com>
To: Christoph Lameter <clameter@sgi.com>
Cc: Anton Blanchard <anton@samba.org>,
akpm@osdl.org, linuxppc-dev@ozlabs.org,
Paul Mackerras <paulus@samba.org>,
linux-kernel@vger.kernel.org
Subject: Re: kernel BUG in __cache_alloc_node at linux-2.6.git/mm/slab.c:3177!
Date: Thu, 19 Oct 2006 15:37:09 -0500 [thread overview]
Message-ID: <1161290229.8946.51.camel@farscape> (raw)
In-Reply-To: <Pine.LNX.4.64.0610190959560.8433@schroedinger.engr.sgi.com>
On Thu, 2006-19-10 at 10:03 -0700, Christoph Lameter wrote:
> I would expect this patch to fix your issues. This will allow fallback
> allocations to occur in the page allocator during slab bootstrap. This
> means your per node queues will be contaminated as they were before. After
> the slab allocator is fully booted then the per node queues will become
> gradually become node clean.
>
> I think it would be better if the PPC arch would fix this issue
> by either making memory available on node 0 or setting up node 1 as
> the boot node.
>
This didnt fix the problem on my box. I tried this both against mm and
linux-2.6.git
> Signed-off-by: Christoph Lameter <clameter@sgi.com>
>
> Index: linux-2.6.19-rc2-mm1/mm/slab.c
> ===================================================================
> --- linux-2.6.19-rc2-mm1.orig/mm/slab.c 2006-10-19 11:54:24.000000000 -0500
> +++ linux-2.6.19-rc2-mm1/mm/slab.c 2006-10-19 11:59:24.208194796 -0500
> @@ -1589,7 +1589,10 @@ static void *kmem_getpages(struct kmem_c
> * the needed fallback ourselves since we want to serve from our
> * per node object lists first for other nodes.
> */
> - flags |= cachep->gfpflags | GFP_THISNODE;
> + if (g_cpucache_up != FULL)
> + flags |= cachep->gfpflags;
> + else
> + flags |= cachep->gfpflags | GFP_THISNODE;
>
> page = alloc_pages_node(nodeid, flags, cachep->gfporder);
> if (!page)
> _______________________________________________
> Linuxppc-dev mailing list
> Linuxppc-dev@ozlabs.org
> https://ozlabs.org/mailman/listinfo/linuxppc-dev
next prev parent reply other threads:[~2006-10-19 20:37 UTC|newest]
Thread overview: 47+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-10-13 18:41 kernel BUG in __cache_alloc_node at linux-2.6.git/mm/slab.c:3177! Will Schmidt
2006-10-13 19:05 ` Christoph Lameter
2006-10-13 19:53 ` Will Schmidt
2006-10-13 20:57 ` Will Schmidt
2006-10-13 21:22 ` Nathan Lynch
2006-10-13 21:34 ` Anton Blanchard
2006-10-13 22:01 ` Mike Kravetz
2006-10-13 22:22 ` Christoph Lameter
2006-10-16 16:00 ` Will Schmidt
2006-10-16 19:20 ` Will Schmidt
2006-10-16 19:25 ` Christoph Lameter
2006-10-16 20:50 ` Will Schmidt
2006-10-16 23:37 ` Christoph Lameter
2006-10-18 6:11 ` Paul Mackerras
2006-10-18 15:12 ` Christoph Lameter
2006-10-18 21:19 ` Paul Mackerras
2006-10-18 21:26 ` Christoph Lameter
2006-10-18 21:49 ` Christoph Lameter
2006-10-19 5:03 ` Paul Mackerras
2006-10-19 16:16 ` Christoph Lameter
2006-10-19 16:30 ` Anton Blanchard
2006-10-19 16:49 ` Christoph Lameter
2006-10-19 22:23 ` Paul Mackerras
2006-10-19 22:31 ` Christoph Lameter
2006-10-20 7:18 ` Paul Mackerras
2006-10-20 14:18 ` Andy Whitcroft
2006-10-20 14:31 ` [PATCH] Reintroduce NODES_SPAN_OTHER_NODES for powerpc Andy Whitcroft
2006-10-20 16:30 ` Mel Gorman
2006-10-20 14:59 ` kernel BUG in __cache_alloc_node at linux-2.6.git/mm/slab.c:3177! Mike Kravetz
2006-10-20 15:19 ` Will Schmidt
2006-10-20 16:00 ` Andy Whitcroft
2006-10-20 17:09 ` Andrew Morton
2006-10-20 17:46 ` Christoph Lameter
2006-10-20 18:07 ` Andy Whitcroft
2006-10-20 17:13 ` Will Schmidt
2006-10-20 17:34 ` Christoph Lameter
2006-10-20 22:54 ` Paul Mackerras
2006-10-19 17:03 ` Christoph Lameter
2006-10-19 18:07 ` Christoph Lameter
2006-10-19 20:37 ` Will Schmidt [this message]
2006-10-19 21:28 ` Christoph Lameter
2006-10-19 21:43 ` Will Schmidt
2006-10-19 22:00 ` Christoph Lameter
2006-10-19 21:39 ` Christoph Lameter
2006-10-19 20:38 ` Will Schmidt
2006-10-19 21:30 ` Christoph Lameter
2006-10-18 16:06 ` Christoph Lameter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1161290229.8946.51.camel@farscape \
--to=will_schmidt@vnet.ibm.com \
--cc=akpm@osdl.org \
--cc=anton@samba.org \
--cc=clameter@sgi.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@ozlabs.org \
--cc=paulus@samba.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox