* [PATCH] 2.6.19.-rc2-mm2 compile fix for sclp_tty
@ 2006-10-20 12:53 Martin Peschke
2006-10-20 13:21 ` Alan Cox
0 siblings, 1 reply; 2+ messages in thread
From: Martin Peschke @ 2006-10-20 12:53 UTC (permalink / raw)
To: Andrew Morton; +Cc: linux-kernel
Extern declaration of tty_std_termios in sclp_tty was a hack
which is obsolete.
CC drivers/s390/char/sclp_tty.o
drivers/s390/char/sclp_tty.c:63: error: conflicting types for 'tty_std_termios'
include/linux/tty.h:261: error: previous declaration of 'tty_std_termios' was here
drivers/s390/char/sclp_tty.c: In function 'sclp_tty_init':
drivers/s390/char/sclp_tty.c:790: error: incompatible types in assignment
make[2]: *** [drivers/s390/char/sclp_tty.o] Error 1
make[1]: *** [drivers/s390/char] Error 2
make: *** [drivers/s390] Error 2
Kernel compilation...FAILED
Signed-off-by: Martin Peschke <mp3@de.ibm.com>
Acked-by: Peter Oberparleiter <oberpar@de.ibm.com>
---
sclp_tty.c | 2 --
1 files changed, 2 deletions(-)
--- a/drivers/s390/char/sclp_tty.c 2006-10-19 23:10:31.000000000 +0200
+++ b/drivers/s390/char/sclp_tty.c 2006-10-19 23:10:32.000000000 +0200
@@ -60,8 +60,6 @@ static unsigned short int sclp_tty_chars
struct tty_driver *sclp_tty_driver;
-extern struct termios tty_std_termios;
-
static struct sclp_ioctls sclp_ioctls;
static struct sclp_ioctls sclp_ioctls_init =
{
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] 2.6.19.-rc2-mm2 compile fix for sclp_tty
2006-10-20 12:53 [PATCH] 2.6.19.-rc2-mm2 compile fix for sclp_tty Martin Peschke
@ 2006-10-20 13:21 ` Alan Cox
0 siblings, 0 replies; 2+ messages in thread
From: Alan Cox @ 2006-10-20 13:21 UTC (permalink / raw)
To: Martin Peschke; +Cc: Andrew Morton, linux-kernel
Ar Gwe, 2006-10-20 am 14:53 +0200, ysgrifennodd Martin Peschke:
> Extern declaration of tty_std_termios in sclp_tty was a hack
> which is obsolete.
>
> CC drivers/s390/char/sclp_tty.o
> drivers/s390/char/sclp_tty.c:63: error: conflicting types for 'tty_std_termios'
> include/linux/tty.h:261: error: previous declaration of 'tty_std_termios' was here
> drivers/s390/char/sclp_tty.c: In function 'sclp_tty_init':
> drivers/s390/char/sclp_tty.c:790: error: incompatible types in assignment
> make[2]: *** [drivers/s390/char/sclp_tty.o] Error 1
> make[1]: *** [drivers/s390/char] Error 2
> make: *** [drivers/s390] Error 2
> Kernel compilation...FAILED
>
> Signed-off-by: Martin Peschke <mp3@de.ibm.com>
> Acked-by: Peter Oberparleiter <oberpar@de.ibm.com>
Acked-by: Alan Cox <alan@redhat.com>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2006-10-20 13:18 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2006-10-20 12:53 [PATCH] 2.6.19.-rc2-mm2 compile fix for sclp_tty Martin Peschke
2006-10-20 13:21 ` Alan Cox
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox