From: Nigel Cunningham <ncunningham@linuxmail.org>
To: "Rafael J. Wysocki" <rjw@sisk.pl>
Cc: LKML <linux-kernel@vger.kernel.org>, Linux PM <linux-pm@osdl.org>,
suspend2-devel <suspend2-devel@lists.suspend2.net>
Subject: Re: [PATCH] Add include/linux/freezer.h and move definitions from sched.h
Date: Sun, 22 Oct 2006 08:27:21 +1000 [thread overview]
Message-ID: <1161469641.17061.18.camel@nigel.suspend2.net> (raw)
In-Reply-To: <200610211541.19050.rjw@sisk.pl>
Hi.
On Sat, 2006-10-21 at 15:41 +0200, Rafael J. Wysocki wrote:
> On Saturday, 21 October 2006 14:21, Nigel Cunningham wrote:
> > Move process freezing functions from include/linux/sched.h to freezer.h,
>
> Hm, I'd rather move them to suspend.h. Is there any reason for introducing
> yet another header file?
Suspend.h sounds reasonable. I picked freezer.h because I thought it
made the purpose of the #include simple and crystal clear, and doesn't
pull in other dependencies (my freezer.h depends on nothing else, where
as suspend.h already depends on:
#if defined(CONFIG_X86) || defined(CONFIG_FRV) || defined(CONFIG_PPC32)
#include <asm/suspend.h>
#endif
#include <linux/swap.h>
#include <linux/notifier.h>
#include <linux/init.h>
#include <linux/pm.h>
That said, suspend.h isn't anything like sched.h itself :)
Nigel
prev parent reply other threads:[~2006-10-21 22:27 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-10-21 12:21 [PATCH] Add include/linux/freezer.h and move definitions from sched.h Nigel Cunningham
2006-10-21 12:42 ` [linux-pm] " Pavel Machek
2006-10-21 13:41 ` Rafael J. Wysocki
2006-10-21 22:27 ` Nigel Cunningham [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1161469641.17061.18.camel@nigel.suspend2.net \
--to=ncunningham@linuxmail.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@osdl.org \
--cc=rjw@sisk.pl \
--cc=suspend2-devel@lists.suspend2.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox