From: Thomas Gleixner <tglx@linutronix.de>
To: sergio@sergiomb.no-ip.org
Cc: Lee Revell <rlrevell@joe-job.com>, Ingo Molnar <mingo@elte.hu>,
linux-kernel@vger.kernel.org, John Stultz <johnstul@us.ibm.com>,
"Paul E. McKenney" <paulmck@us.ibm.com>,
Dipankar Sarma <dipankar@in.ibm.com>,
Arjan van de Ven <arjan@infradead.org>,
Mike Galbraith <efault@gmx.de>,
Daniel Walker <dwalker@mvista.com>,
Manish Lachwani <mlachwani@mvista.com>,
bastien.dugue@bull.net
Subject: Re: -rt7 announcement? (was Re: 2.6.18-rt6) and more info about a compile error
Date: Tue, 24 Oct 2006 06:38:25 +0200 [thread overview]
Message-ID: <1161664706.22373.48.camel@localhost.localdomain> (raw)
In-Reply-To: <1161653206.2996.17.camel@localhost.portugal>
On Tue, 2006-10-24 at 02:26 +0100, Sergio Monteiro Basto wrote:
> On Mon, 2006-10-23 at 16:40 -0400, Lee Revell wrote:
> > On Mon, 2006-10-23 at 21:26 +0100, Sergio Monteiro Basto wrote:
> > > rt7 should be to be applied on 2.6.18.1
> > > still for 2.6.18
> > >
> >
> > The -rt patch has always been against the most recent base kernel. It
> > could be rebased against -stable but that would be more work for the
> > maintainers...
>
> For me the most recent stable kernel is 2.6.18.1.
> Normally change for .1 are very small but in this case I got 1, just 1,
> reject which I don't know to fix and prefer don't try it. My luck is the
> rej in a sparc arch and I can ignore it.
-rtXX is always against 2.6.X, never against the .stable versions.
> I got this compile error if I don't use CONFIG_PREEMPT_BKL in .config
>
> kernel/rtmutex.c:938:48: error: macro "rt_release_bkl" passed 2
> arguments, but takes just 1
> kernel/rtmutex.c: In function 'rt_mutex_slowlock':
> kernel/rtmutex.c:938: error: 'rt_release_bkl' undeclared (first use in
> this function)
> kernel/rtmutex.c:938: error: (Each undeclared identifier is reported
> only once
> kernel/rtmutex.c:938: error: for each function it appears in.)
Fix below.
tglx
Index: linux-2.6.18/kernel/rtmutex.c
===================================================================
--- linux-2.6.18.orig/kernel/rtmutex.c 2006-10-24 06:33:02.000000000 +0200
+++ linux-2.6.18/kernel/rtmutex.c 2006-10-24 06:31:55.000000000 +0200
@@ -902,7 +902,10 @@ static inline void rt_reacquire_bkl(int
}
#else
-# define rt_release_bkl(x) (-1)
+static inline int rt_release_bkl(struct rt_mutex *lock, unsigned long flags)
+{
+ return -1;
+}
# define rt_reacquire_bkl(x) do { } while (0)
#endif
next prev parent reply other threads:[~2006-10-24 4:37 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-10-18 8:39 2.6.18-rt6 Ingo Molnar
2006-10-18 9:14 ` 2.6.18-rt6 Sébastien Dugué
2006-10-18 10:05 ` 2.6.18-rt6 Ingo Molnar
2006-10-18 14:53 ` 2.6.18-rt6 Paul E. McKenney
2006-10-18 21:07 ` 2.6.18-rt6 Esben Nielsen
2006-10-20 0:23 ` 2.6.18-rt6 Sergio Monteiro Basto
2006-10-20 0:59 ` 2.6.18-rt6 john stultz
2006-10-23 20:33 ` 2.6.18-rt6 and compile fail with rt7 on x86_64 Sergio Monteiro Basto
2006-10-20 15:00 ` 2.6.18-rt6 Lee Revell
2006-10-20 15:53 ` 2.6.18-rt6 Mark Knecht
2006-10-23 16:34 ` -rt7 announcement? (was Re: 2.6.18-rt6) Lee Revell
2006-10-23 18:29 ` Mark Knecht
2006-10-23 18:35 ` Thomas Gleixner
2006-10-23 18:44 ` Mark Knecht
2006-10-23 18:59 ` Thomas Gleixner
2006-10-23 20:09 ` Mark Knecht
2006-10-23 18:49 ` Lee Revell
2006-10-23 18:58 ` Thomas Gleixner
2006-10-23 20:26 ` Sergio Monteiro Basto
2006-10-23 20:40 ` Lee Revell
2006-10-24 1:26 ` -rt7 announcement? (was Re: 2.6.18-rt6) and more info about a compile error Sergio Monteiro Basto
2006-10-24 4:38 ` Thomas Gleixner [this message]
2006-10-24 16:48 ` Daniel Walker
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1161664706.22373.48.camel@localhost.localdomain \
--to=tglx@linutronix.de \
--cc=arjan@infradead.org \
--cc=bastien.dugue@bull.net \
--cc=dipankar@in.ibm.com \
--cc=dwalker@mvista.com \
--cc=efault@gmx.de \
--cc=johnstul@us.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=mlachwani@mvista.com \
--cc=paulmck@us.ibm.com \
--cc=rlrevell@joe-job.com \
--cc=sergio@sergiomb.no-ip.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox