Re: [KJ][PATCH] Correct misc_register return code handling in several drivers

Jesper Juhl
2006-11-02T00:05:54Z

On 01/11/06, Neil Horman <nhorman@tuxdriver.com> wrote:
> Hey all-
> Since Andrew hasn't incorporated this patch yet, and I had the time, I
> redid the patch taking Benjamin's INIT_LIST_HEAD and Joes mmtimer cleanup into
> account. New patch attached, replacing the old one, everything except the
> aforementioned cleanups is identical.
>
> Thanks & Regards
> Neil
>
> Signed-off-by: Neil Horman <nhorman@tuxdriver.com>
>
> +out4:
> + for_each_online_node(node) {
> + kfree(timers[node]);
> + }
> +out3:
> + misc_deregister(&mmtimer_miscdev);
> +out2:
> + free_irq(SGI_MMTIMER_VECTOR, NULL);
> +out1:
> + return -1;

Very nitpicky little thing, but shouldn't the labels start at column
1, not column 0 ?
I thought that was standard practice (apparently labels at column 0
can confuse 'patch').

Hmm, I guess that should be defined once and for all in
Documentation/CodingStyle

--
Jesper Juhl <jesper.juhl@gmail.com>
Don't top-post http://www.catb.org/~esr/jargon/html/T/top-post.html
Plain text mails only, please http://www.expita.com/nomime.html