Re: [PATCH 11/16] sysfs: add support for adding/removing spu sysfs attributes

Heiko Carstens
2006-10-25T07:52:43Z

> +int cpu_add_sysdev_attr(struct sysdev_attribute *attr)
> +{
> + int cpu;
> +
> + mutex_lock(&cpu_mutex);
> +
> + for_each_possible_cpu(cpu) {
> + sysdev_create_file(get_cpu_sysdev(cpu), attr);
> + }
> +
> + mutex_unlock(&cpu_mutex);
> + return 0;
> +}

You probably should check for errors on sysdev_create_file, clean up and
return an error number instead of always 0.
This is true for all the new functions here.