From: Richard Purdie <rpurdie@openedhand.com>
To: Nick Piggin <nickpiggin@yahoo.com.au>
Cc: kernel list <linux-kernel@vger.kernel.org>,
Andrew Morton <akpm@osdl.org>
Subject: Re: [PATCH, RFC/T] Fix handling of write failures to swap devices
Date: Fri, 27 Oct 2006 10:35:37 +0100 [thread overview]
Message-ID: <1161941737.5019.100.camel@localhost.localdomain> (raw)
In-Reply-To: <4541C1B2.7070003@yahoo.com.au>
On Fri, 2006-10-27 at 18:22 +1000, Nick Piggin wrote:
> This is the right approach to handling swap write errors. However, you need
> to cut down on the amount of code duplication.
I've just looked at this and there isn't that much code duplicated, just
a couple of big comment blocks which make it look like that. Those
sections are similar in spirit but have been modified to work under
different circumstances. Having looked again, I don't think its worth
trying to merge them as it will become too unreadable.
Cheers,
Richard
next prev parent reply other threads:[~2006-10-27 9:35 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-10-27 7:59 [PATCH, RFC/T] Fix handling of write failures to swap devices Richard Purdie
2006-10-27 8:22 ` Nick Piggin
2006-10-27 8:44 ` Richard Purdie
2006-10-28 4:55 ` Nick Piggin
2006-10-28 10:43 ` Richard Purdie
2006-10-28 12:10 ` Nick Piggin
2006-10-30 11:55 ` Richard Purdie
2006-11-01 5:26 ` Nick Piggin
2006-11-01 9:24 ` Richard Purdie
2006-11-02 23:26 ` Richard Purdie
2006-12-13 11:43 ` Richard Purdie
2006-11-01 5:36 ` Nick Piggin
2006-11-01 9:32 ` Richard Purdie
2006-10-27 9:35 ` Richard Purdie [this message]
2006-10-27 21:19 ` Andrew Morton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1161941737.5019.100.camel@localhost.localdomain \
--to=rpurdie@openedhand.com \
--cc=akpm@osdl.org \
--cc=linux-kernel@vger.kernel.org \
--cc=nickpiggin@yahoo.com.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox