From: Marcel Holtmann <marcel@holtmann.org>
To: Peter Zijlstra <a.p.zijlstra@chello.nl>
Cc: linux-kernel <linux-kernel@vger.kernel.org>,
Andrew Morton <akpm@osdl.org>,
"James E.J. Bottomley" <James.Bottomley@HansenPartnership.com>,
Greg KH <gregkh@suse.de>,
Markus Lidel <markus.lidel@shadowconnect.com>,
Ingo Molnar <mingo@elte.hu>,
Arjan van de Ven <arjan@infradead.org>
Subject: Re: [PATCH] lockdep: annotate DECLARE_WAIT_QUEUE_HEAD
Date: Mon, 30 Oct 2006 09:30:35 +0100 [thread overview]
Message-ID: <1162197035.24333.5.camel@localhost> (raw)
In-Reply-To: <1162045659.24143.149.camel@taijtu>
Hi Peter,
> kernel: INFO: trying to register non-static key.
> kernel: the code is fine but needs lockdep annotation.
> kernel: turning off the locking correctness validator.
> kernel: [<c04051ed>] show_trace_log_lvl+0x58/0x16a
> kernel: [<c04057fa>] show_trace+0xd/0x10
> kernel: [<c0405913>] dump_stack+0x19/0x1b
> kernel: [<c043b1e2>] __lock_acquire+0xf0/0x90d
> kernel: [<c043bf70>] lock_acquire+0x4b/0x6b
> kernel: [<c061472f>] _spin_lock_irqsave+0x22/0x32
> kernel: [<c04363d3>] prepare_to_wait+0x17/0x4b
> kernel: [<f89a24b6>] lpfc_do_work+0xdd/0xcc2 [lpfc]
> kernel: [<c04361b9>] kthread+0xc3/0xf2
> kernel: [<c0402005>] kernel_thread_helper+0x5/0xb
>
> Another case of non-static lockdep keys; duplicate the paradigm set by
> DECLARE_COMPLETION_ONSTACK and introduce DECLARE_WAIT_QUEUE_HEAD_ONSTACK.
>
> Signed-off-by: Peter Zijlstra <a.p.zijlstra@chello.nl>
for the Bluetooth subsystem part of this patch:
Signed-off-by: Marcel Holtmann <marcel@holtmann.org>
Regards
Marcel
prev parent reply other threads:[~2006-10-30 8:31 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-10-28 14:27 [PATCH] lockdep: annotate DECLARE_WAIT_QUEUE_HEAD Peter Zijlstra
2006-10-30 8:30 ` Marcel Holtmann [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1162197035.24333.5.camel@localhost \
--to=marcel@holtmann.org \
--cc=James.Bottomley@HansenPartnership.com \
--cc=a.p.zijlstra@chello.nl \
--cc=akpm@osdl.org \
--cc=arjan@infradead.org \
--cc=gregkh@suse.de \
--cc=linux-kernel@vger.kernel.org \
--cc=markus.lidel@shadowconnect.com \
--cc=mingo@elte.hu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox