Re: [PATCH 6/7] Add APIC accessors to paravirt-ops.

Andi Kleen
2006-10-29T16:42:28Z

>
> /* nop stub */
> static void native_nop(void)
> @@ -382,6 +384,26 @@ static fastcall void native_io_delay(voi
> asm volatile("outb %al,$0x80");
> }
>
> +#ifdef CONFIG_X86_LOCAL_APIC

It would be nicer if you renamed the functions in apic.h to native_apic_*
and then do

#ifdef CONFIG_PARAVIRT
#include <asm/paravirt.h>
#else
#define apic_read native_apic_read
...
#endif

This way we wouldn't get that much duplication.

This might apply to at least some of the other paravirt ops too.

-Andi