Re: [PATCH 2/7] paravirtualization: Patch inline replacements for common paravirt operations.

Andrew Morton
2006-11-01T23:28:22Z

On Wed, 01 Nov 2006 21:28:13 +1100
Rusty Russell <rusty@rustcorp.com.au> wrote:

> +void apply_paravirt(struct paravirt_patch *start, struct paravirt_patch *end)
> +{
> + struct paravirt_patch *p;
> + int i;
> +
> + for (p = start; p < end; p++) {
> + unsigned int used;
> +
> + used = paravirt_ops.patch(p->instrtype, p->clobbers, p->instr,
> + p->len);
> +#ifdef CONFIG_DEBUG_KERNEL
> + /* Deliberately clobber regs using "not %reg" to find bugs. */

That would be considered to be abusive of CONFIG_DEBUG_KERNEL. A
CONFIG_DEBUG_PARAVIRT which depends on CONFIG_DEBUG_KERNEL would be more
harmonious.