Re: [BUG] 2.6.19-rc3 autofs crash on my IA64 box

[Ian Kent <raven@themaw.net>]

On Thu, 2006-11-02 at 18:51 +0900, Yasunori Goto wrote:
> Hello.
> 
> > hi,
> >   2.6.19-rc3 kernel crashes on my IA64 box, it seems the problem
> > of autofs fs. I debug this problem, if autofs kernel does not
> > match daemon version, it will call autofs_catatonic_mode.
> > But at that time sbi->pipe is NULL.
> > 
> > void autofs_catatonic_mode(struct autofs_sb_info *sbi)
> > {
> >    .........
> >    fput(sbi->pipe);        /* Close the pipe */
> > 	^^^^^^^^^^^^
> >  	sbi->pipe seems NULL;
> >    autofs_hash_dputall(&sbi->dirhash); /* Remove all dentry pointers */
> > }
> > 
> 
> My box crashed too.
> 
> Following fix does not seem enough.
> http://marc.theaimsgroup.com/?l=linux-kernel&m=116110204104327&w=2

I'm not surprised it addresses a completely different problem.

> If version does not match at autofs_fill_super(), then sbi->pipe
> is not set yet.
> I suppose something like following patch is necessary.

At least but I'll need to check a bit further into this and the autofs4
module should be updated in a similar manner. Even though it will
support the latest requested version it should still handle this error
case.

Ian