public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Alan Cox <alan@lxorguk.ukuu.org.uk>
To: Luugi Marsan <luugi.marsan@amd.com>
Cc: linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/2] Add Legacy IDE mode support for SB600 SATA
Date: Fri, 03 Nov 2006 19:30:16 +0000	[thread overview]
Message-ID: <1162582216.12810.40.camel@localhost.localdomain> (raw)
In-Reply-To: <20061103185420.B3FA6CBD48@localhost.localdomain>

Ar Gwe, 2006-11-03 am 13:54 -0500, ysgrifennodd Luugi Marsan:
> From: conke.hu@amd.com
> 
> ATI SB600 SATA controller supports 4 modes: Legacy IDE, Native IDE, AHCI and RAID.IDE modes are used for compatibility with some old OS without AHCI driver,but now they are not necessary for Linux since the kernel has supported AHCI.Some BIOS set Legacy IDE as SB600 SATA's default mode, but the AHCI driver cannot run in Legacy IDE.So, we should set the controller back to AHCI mode if it has been set as IDE by BIOS.
> 
> Signed-off-by:  Luugi Marsan <luugi.marsan@amd.com>

NAK

This should only be done if AHCI is configured into the kernel, so wants
a #ifdef check adding. Otherwise people using SB600 via the legacy ide
layer will get burned.

  reply	other threads:[~2006-11-03 19:26 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-11-03 18:54 [PATCH 1/2] Add Legacy IDE mode support for SB600 SATA Luugi Marsan
2006-11-03 19:30 ` Alan Cox [this message]
2006-11-05 12:17   ` Conke Hu
2006-11-05 12:45     ` Alan Cox
2006-11-05 13:38       ` Conke Hu
2006-11-05 15:08         ` Alan Cox
2006-11-05 13:10     ` Arjan van de Ven

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1162582216.12810.40.camel@localhost.localdomain \
    --to=alan@lxorguk.ukuu.org.uk \
    --cc=linux-kernel@vger.kernel.org \
    --cc=luugi.marsan@amd.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox