Re: lib/iomap.c mmio_{in,out}s* vs. __raw_* accessors

Benjamin Herrenschmidt
2006-11-05T05:30:53Z

On Sun, 2006-11-05 at 16:08 +1100, Benjamin Herrenschmidt wrote:
> > Can you work based on something like this instead?
> >
> > (Totally untested, I just did this as an example of what I think is a lot
> > more maintainable)
>
> Yup, that would definitely work for me.
>
> I'll do the same for the repeat ops..

I'm blind, didn't see you did it for them already :-)

Ok, your patch builds fine here. I can't test at the moment as I don't
have a machine at hand that has a device whose driver uses the ops in
iomap though, but I can't see any reason why it wouldn't work if it
builds, so as far as I'm concerned, that's good to go in 2.6.20.
(earlier if you wish but I won't submit the patch doing the powerpc
changes that makes me use those change before 2.6.20 obviously :-)

Cheers,
Ben.