From: Benjamin Herrenschmidt <benh@kernel.crashing.org>
To: Linus Torvalds <torvalds@osdl.org>
Cc: Russell King <rmk+lkml@arm.linux.org.uk>,
Linux Kernel list <linux-kernel@vger.kernel.org>,
Jeff Garzik <jgarzik@pobox.com>, Andrew Morton <akpm@osdl.org>,
"David S. Miller" <davem@davemloft.net>,
Paul Mackerras <paulus@samba.org>
Subject: Re: lib/iomap.c mmio_{in,out}s* vs. __raw_* accessors
Date: Mon, 06 Nov 2006 13:56:03 +1100 [thread overview]
Message-ID: <1162781764.28571.275.camel@localhost.localdomain> (raw)
In-Reply-To: <1162704529.28571.164.camel@localhost.localdomain>
> Ok, your patch builds fine here. I can't test at the moment as I don't
> have a machine at hand that has a device whose driver uses the ops in
> iomap though, but I can't see any reason why it wouldn't work if it
> builds, so as far as I'm concerned, that's good to go in 2.6.20.
> (earlier if you wish but I won't submit the patch doing the powerpc
> changes that makes me use those change before 2.6.20 obviously :-)
In fact, you might want to push it to 2.6.19 since it fixes a bug
(current _be operations are incorrect for PIO without the patch).
Cheers,
Ben.
next prev parent reply other threads:[~2006-11-06 2:56 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-11-04 7:52 lib/iomap.c mmio_{in,out}s* vs. __raw_* accessors Benjamin Herrenschmidt
2006-11-04 14:06 ` Russell King
2006-11-04 22:17 ` Benjamin Herrenschmidt
2006-11-04 23:52 ` Linus Torvalds
2006-11-05 1:10 ` Benjamin Herrenschmidt
2006-11-05 3:32 ` Benjamin Herrenschmidt
2006-11-05 3:46 ` Linus Torvalds
2006-11-05 3:55 ` Benjamin Herrenschmidt
2006-11-05 4:00 ` Benjamin Herrenschmidt
2006-11-05 4:16 ` Linus Torvalds
2006-11-05 4:38 ` Benjamin Herrenschmidt
2006-11-05 5:00 ` Linus Torvalds
2006-11-05 5:08 ` Benjamin Herrenschmidt
2006-11-05 5:28 ` Benjamin Herrenschmidt
2006-11-06 2:56 ` Benjamin Herrenschmidt [this message]
2006-11-06 3:13 ` Linus Torvalds
2006-11-06 4:50 ` Benjamin Herrenschmidt
2006-11-05 3:34 ` Linus Torvalds
2006-11-05 3:49 ` Benjamin Herrenschmidt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1162781764.28571.275.camel@localhost.localdomain \
--to=benh@kernel.crashing.org \
--cc=akpm@osdl.org \
--cc=davem@davemloft.net \
--cc=jgarzik@pobox.com \
--cc=linux-kernel@vger.kernel.org \
--cc=paulus@samba.org \
--cc=rmk+lkml@arm.linux.org.uk \
--cc=torvalds@osdl.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox