public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Thomas Gleixner <tglx@linutronix.de>
To: Andrew Morton <akpm@osdl.org>
Cc: Ingo Molnar <mingo@elte.hu>, teunis <teunis@wintersgift.com>,
	linux-kernel@vger.kernel.org, Dmitry Torokhov <dtor@mail.ru>,
	john stultz <johnstul@us.ibm.com>, Len Brown <lenb@kernel.org>,
	Arjan van de Ven <arjan@infradead.org>
Subject: Re: various laptop nagles - any suggestions?   (note: 2.6.19-rc2-mm1 but applies to multiple kernels)
Date: Wed, 08 Nov 2006 23:28:13 +0100	[thread overview]
Message-ID: <1163024893.8335.97.camel@localhost.localdomain> (raw)
In-Reply-To: <20061107231903.99156678.akpm@osdl.org>

On Tue, 2006-11-07 at 23:19 -0800, Andrew Morton wrote:
> I have a bad feeling about the hrtimer+dynticks patches, frankly.  We had a
> lot of discussion and review of the original patchset and it almost all
> seemed OK apart from this tsc-goes-silly problem.  But then this lot:
> 
> highres-timer-core-fix-status-check.patch
> highres-timer-core-fix-commandline-setup.patch
> clockevents-smp-on-up-features.patch
> highres-depend-on-clockevents.patch

Trivial fixups

> i386-apic-cleanup.patch
> pm-timer-allow-early-access.patch
> i386-lapic-timer-calibration.patch

This one solves real problems:
- hang in lapic calibration caused by buggy PIT readouts
- wrong lapic calibration seen on my VAIO CoreDuo (also reported by
others)

I did the i386-apic-cleanup.patch first, as I really did not want to add
more mess to the existing one. Sigh, I should have done that before
adding the clock events support.

> clockevents-add-broadcast-support.patch
> clockevents-add-broadcast-support-fix.patch
> acpi-include-apic-h.patch
> acpi-include-apic-h-fix.patch
> acpi-keep-track-of-timer-broadcast.patch
> i386-apic-timer-use-clockevents-broadcast.patch

Needs review

> acpi-verify-lapic-timer.patch
> acpi-verify-lapic-timer-exports.patch
> acpi-verify-lapic-timer-fix.patch

Those can be dropped, as the approach was too naive. At least we know,
that it can be detected, but this needs more effort to get this
straight.

I'm resorting to the following solution for now:

- Disable local APIC timer as the next event source on UP systems by
default.
- Add a command line option to enable it on sane hardware, as it is
faster.

I send a patch tomorrow morning including the fix for the OOPS reported
by Benoit Boissinot. -ETOOTIRED

If this works on your jinxed VAIO, I do a complete replacement rollup
for review.

	tglx




  reply	other threads:[~2006-11-08 22:26 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-10-19 16:05 various laptop nagles - any suggestions? (note: 2.6.19-rc2-mm1 but applies to multiple kernels) teunis
2006-10-20  2:41 ` Andrew Morton
2006-10-20 16:30   ` teunis
2006-10-20 18:07     ` Andrew Morton
2006-10-20 18:13       ` Thomas Gleixner
2006-10-20 18:26         ` Andrew Morton
2006-10-20 18:37           ` Thomas Gleixner
2006-10-20 18:46           ` Thomas Gleixner
2006-10-20 19:15             ` Andrew Morton
2006-10-20 20:37               ` Ingo Molnar
2006-10-20 20:54                 ` Andrew Morton
2006-10-20 20:56                   ` Ingo Molnar
2006-10-21  1:25                     ` Andrew Morton
2006-10-21  9:49                       ` Thomas Gleixner
2006-10-22 21:22                         ` Thomas Gleixner
2006-11-08  7:19                           ` Andrew Morton
2006-11-08 22:28                             ` Thomas Gleixner [this message]
2006-10-21 14:52           ` Arjan van de Ven
2006-10-20 19:13       ` Dmitry Torokhov
2006-10-20 22:26         ` teunis

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1163024893.8335.97.camel@localhost.localdomain \
    --to=tglx@linutronix.de \
    --cc=akpm@osdl.org \
    --cc=arjan@infradead.org \
    --cc=dtor@mail.ru \
    --cc=johnstul@us.ibm.com \
    --cc=lenb@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@elte.hu \
    --cc=teunis@wintersgift.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox