From: "Sébastien Dugué" <sebastien.dugue@bull.net>
To: Badari Pulavarty <pbadari@us.ibm.com>
Cc: "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Suparna Bhattacharya <suparna@in.ibm.com>,
Ulrich Drepper <drepper@redhat.com>,
Zach Brown <zach.brown@oracle.com>, Dave Jones <davej@redhat.com>,
Jean Pierre Dion <jean-pierre.dion@bull.net>,
"linux-aio@kvack.org" <linux-aio@kvack.org>
Subject: Re: [PATCH -mm 3/3][AIO] - AIO completion signal notification
Date: Fri, 10 Nov 2006 10:22:10 +0100 [thread overview]
Message-ID: <1163150530.3879.61.camel@frecb000686> (raw)
In-Reply-To: <1163099886.29807.20.camel@dyn9047017100.beaverton.ibm.com>
On Thu, 2006-11-09 at 11:18 -0800, Badari Pulavarty wrote:
> On Thu, 2006-11-09 at 16:59 +0100, Sébastien Dugué wrote:
>
> > @@ -1549,8 +1657,7 @@ int fastcall io_submit_one(struct kioctx
> > ssize_t ret;
> >
> > /* enforce forwards compatibility on users */
> > - if (unlikely(iocb->aio_reserved1 || iocb->aio_reserved2 ||
> > - iocb->aio_reserved3)) {
> > + if (unlikely(iocb->aio_reserved1)) {
> > pr_debug("EINVAL: io_submit: reserve field set\n");
> > return -EINVAL;
>
> Is there a reason for not checking "aio_reserved3" ?
> You are still not using it. Right ?
>
Yep, forgot this one.
Thanks,
Sébastien.
next prev parent reply other threads:[~2006-11-10 9:23 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-11-09 15:55 [PATCH -mm 0/3][AIO] - AIO completion signal notification Sébastien Dugué
2006-11-09 15:58 ` [PATCH -mm 1/3][AIO] " Sébastien Dugué
2006-11-09 15:59 ` [PATCH -mm 2/3][AIO] " Sébastien Dugué
2006-11-09 15:59 ` [PATCH -mm 3/3][AIO] " Sébastien Dugué
2006-11-09 18:46 ` Badari Pulavarty
2006-11-10 9:05 ` Sébastien Dugué
2006-11-09 19:08 ` Christoph Hellwig
2006-11-09 19:27 ` Badari Pulavarty
2006-11-10 9:20 ` Sébastien Dugué
2006-11-10 9:14 ` Sébastien Dugué
2006-11-09 19:18 ` Badari Pulavarty
2006-11-10 9:22 ` Sébastien Dugué [this message]
2006-11-10 1:52 ` Badari Pulavarty
2006-11-10 1:54 ` Badari Pulavarty
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1163150530.3879.61.camel@frecb000686 \
--to=sebastien.dugue@bull.net \
--cc=davej@redhat.com \
--cc=drepper@redhat.com \
--cc=jean-pierre.dion@bull.net \
--cc=linux-aio@kvack.org \
--cc=linux-kernel@vger.kernel.org \
--cc=pbadari@us.ibm.com \
--cc=suparna@in.ibm.com \
--cc=zach.brown@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox