From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner+willy=40w.ods.org-S1946263AbWKJKOU@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1946263AbWKJKOU (ORCPT <rfc822;willy@w.ods.org>);
	Fri, 10 Nov 2006 05:14:20 -0500
Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1946264AbWKJKOU
	(ORCPT <rfc822;linux-kernel-outgoing>);
	Fri, 10 Nov 2006 05:14:20 -0500
Received: from www.osadl.org ([213.239.205.134]:17131 "EHLO mail.tglx.de")
	by vger.kernel.org with ESMTP id S1946263AbWKJKOT (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Fri, 10 Nov 2006 05:14:19 -0500
Subject: Re: [patch 08/19] i386: cleanup apic code
From: Thomas Gleixner <tglx@linutronix.de>
Reply-To: tglx@linutronix.de
To: Arjan van de Ven <arjan@infradead.org>
Cc: Andrew Morton <akpm@osdl.org>, LKML <linux-kernel@vger.kernel.org>,
       Ingo Molnar <mingo@elte.hu>, Len Brown <lenb@kernel.org>,
       John Stultz <johnstul@us.ibm.com>, Andi Kleen <ak@suse.de>,
       Roman Zippel <zippel@linux-m68k.org>
In-Reply-To: <1163153099.3138.642.camel@laptopd505.fenrus.org>
References: <20061109233030.915859000@cruncher.tec.linutronix.de>
	 <20061109233034.987972000@cruncher.tec.linutronix.de>
	 <1163153099.3138.642.camel@laptopd505.fenrus.org>
Content-Type: text/plain
Date: Fri, 10 Nov 2006 11:16:38 +0100
Message-Id: <1163153798.8335.196.camel@localhost.localdomain>
Mime-Version: 1.0
X-Mailer: Evolution 2.6.1 
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
X-Mailing-List: linux-kernel@vger.kernel.org

On Fri, 2006-11-10 at 11:04 +0100, Arjan van de Ven wrote:
> >  
> >  /*
> >   * Knob to control our willingness to enable the local APIC.
> > + *
> > + * -1=force-disable, +1=force-enable
> 
> mind doing 2 defines for these? Makes things more readable I suspect

Yep.

> > -	return maxlvt;
> > +	return APIC_INTEGRATED(GET_APIC_VERSION(v)) ? GET_APIC_MAXLVT(v) : 2;
> >  }
> 
> why not use lapic_is_integrated() here?

oops.

> > \
> > +	if (cpu_has_tsc)
> > +		apic_printk(APIC_VERBOSE, "..... CPU clock speed is "
> 
> please put "approximated at" or something here; or people will call
> supportlines if they bought a 3.4Ghz processor and this shows 3.39999Ghz

:)

> > +EXPORT_SYMBOL(switch_APIC_timer_to_ipi);
> 
> why is this exported at all? Modules really shouldn't be touching apic
> level details.... 

This is exported for ACPI to handle the C3 stops lapic hell.

	tglx