From: Ingo Molnar <mingo@redhat.com>
To: Pavel Emelianov <xemul@openvz.org>
Cc: Andrew Morton <akpm@osdl.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
mingo@elte.hu, Kirill Korotaev <dev@openvz.org>
Subject: Re: [RFC] [PATCH] Fix misrouted interrupts deadlocks
Date: Fri, 10 Nov 2006 15:12:30 +0100 [thread overview]
Message-ID: <1163167950.1980.4.camel@earth> (raw)
In-Reply-To: <455484E4.1020100@openvz.org>
On Fri, 2006-11-10 at 16:55 +0300, Pavel Emelianov wrote:
> - int ok = misrouted_irq(irq);
> + int ok;
> +
> + spin_unlock(&desc->lock);
> + ok = misrouted_irq(irq);
> + spin_lock(&desc->lock);
your fix looks reasonable to me - it's a thinko to call misrouted_irq()
with the descriptor lock still held. (btw., how did you find it -
lockdep spinlock debugging or NMI watchdog?)
Acked-by: Ingo Molnar <mingo@redhat.com>
Ingo
next prev parent reply other threads:[~2006-11-10 14:13 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-11-10 13:55 [RFC] [PATCH] Fix misrouted interrupts deadlocks Pavel Emelianov
2006-11-10 14:12 ` Ingo Molnar [this message]
2006-11-10 14:31 ` Pavel Emelianov
2006-11-20 19:23 ` Vivek Goyal
2006-11-20 19:56 ` Vivek Goyal
2006-11-20 20:52 ` Vivek Goyal
2006-11-21 8:01 ` Pavel Emelianov
2006-11-21 8:10 ` Pavel Emelianov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1163167950.1980.4.camel@earth \
--to=mingo@redhat.com \
--cc=akpm@osdl.org \
--cc=dev@openvz.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=xemul@openvz.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox