From: Benjamin Herrenschmidt <benh@kernel.crashing.org>
To: Len Brown <lenb@kernel.org>
Cc: Greg KH <greg@kroah.com>,
Linux Kernel list <linux-kernel@vger.kernel.org>,
Andrew Morton <akpm@osdl.org>
Subject: Re: [PATCH 2/2] Use dev_sysdata for ACPI and remove firmware_data
Date: Tue, 14 Nov 2006 16:50:13 +1100 [thread overview]
Message-ID: <1163483414.5940.110.camel@localhost.localdomain> (raw)
In-Reply-To: <200611140043.30714.len.brown@intel.com>
> device.firmware_data was born when we went to link Linux devices
> and ACPI devices using device.platform_data and found it was already used.
> You recommended we create a new field to avoid the conflict, and
> IIR the discussion suggested that eventually device.platform_data use
> would get cleaned up and the fields could perhaps some day be combined.
>
> I don't know if we are any closer to that day, before or after this change.
I've audited use of platform data and plan to get rid of it too :-)
(Or actually move it to platform_device where it belongs and fix other
abusers)
> However, I'm fine with Ben's re-name -- it changes no functionality on ACPI-enabled
> systems while potentially deleting an unused pointer/dev on other architectures.
>
> Please ship his patch #2 along with patch #1 that it depends on.
>
> Acked-by: Len Brown <len.brown@intel.com>
Excellent, thanks !
Cheers,
Ben.
prev parent reply other threads:[~2006-11-14 5:50 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-11-09 0:58 [PATCH 2/2] Use dev_sysdata for ACPI and remove firmware_data Benjamin Herrenschmidt
2006-11-10 5:49 ` Greg KH
2006-11-14 5:43 ` Len Brown
2006-11-14 5:50 ` Benjamin Herrenschmidt [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1163483414.5940.110.camel@localhost.localdomain \
--to=benh@kernel.crashing.org \
--cc=akpm@osdl.org \
--cc=greg@kroah.com \
--cc=lenb@kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox