From: Ingo Molnar <mingo@redhat.com>
To: Andrew Morton <akpm@osdl.org>
Cc: Adrian Bunk <bunk@stusta.de>, linux-kernel@vger.kernel.org
Subject: Re: [2.6 patch] arch/i386/kernel/io_apic.c: handle a negative return value
Date: Tue, 14 Nov 2006 07:46:52 +0100 [thread overview]
Message-ID: <1163486812.28401.42.camel@earth> (raw)
In-Reply-To: <20061113164256.805a7497.akpm@osdl.org>
On Mon, 2006-11-13 at 16:42 -0800, Andrew Morton wrote:
> pin = find_isa_irq_pin(8, mp_INT);
> + if (pin == -1) {
> + printk(KERN_ERR "unlock_ExtINT_logic:
> find_isa_irq_pin()
> + "failed\n");
> + return;
> + }
> apic = find_isa_irq_apic(8, mp_INT);
> - if (pin == -1)
> + if (apic == -1) {
> + printk(KERN_ERR "unlock_ExtINT_logic:
> find_isa_irq_apic()
> + "failed\n");
> return;
> + }
as i mentioned it in my mail yesterday, if find_isa_irq_apic() returns
-1 then find_isa_irq_pin() has to return -1 too. But this is obscure and
needs to be documented at least - and your patch is good for
documentation purposes too :-)
Acked-by: Ingo Molnar <mingo@redhat.com>
Ingo
prev parent reply other threads:[~2006-11-14 6:48 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-11-12 17:48 [2.6 patch] arch/i386/kernel/io_apic.c: handle a negative return value Adrian Bunk
2006-11-13 8:08 ` Ingo Molnar
2006-11-14 0:42 ` Andrew Morton
2006-11-14 6:46 ` Ingo Molnar [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1163486812.28401.42.camel@earth \
--to=mingo@redhat.com \
--cc=akpm@osdl.org \
--cc=bunk@stusta.de \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox