Re: [patch] floppy: suspend/resume fix

Rafael J. Wysocki
2006-11-15T21:06:26Z

On Wednesday, 15 November 2006 21:49, Pavel Machek wrote:
> Hi!
>
> > > > > Suspending with mounted floppy is a user error.
> > > >
> > > > Huh? How so?
> > >
> > > Floppy is removable, and you are expected to umount removable devices
> > > before suspend.
> >
> > That seems pretty crude. There are lots of cases where an apparently
> > removable device is/should be preserved properly and left mounted (eg
> > builtin CF).
> >
> > We really want to be smarter than that - which means the drivers ought to
> > be doing stuff in their suspend/resume paths to figure out if the media
> > changed when really possible (eg IDE removable)
> >
> > Floppy is probably not too fixable, but calling it a "user error" is
> > insulting - user expectation is reasonable that suspend/resume should
> > just work. The implementation is just rather trickier/nonsensical in this
> > case.
>
> Yep, it would be nice to do something about that; but I'm not sure how
> this "was media changed" should be implemented, and if it should be
> done in kernel or in userland.

<heresy>
Use something like subfs?
</heresy>

Greetings,
Rafael

--
You never change things by fighting the existing reality.
R. Buckminster Fuller