Re: [openib-general] [PATCH 09/13] Core WQE/CQE Types

Bryan O'Sullivan
2006-11-17T18:18:58Z

Steve Wise wrote:
> T3 WQE and CQE structures, defines, etc...

I notice that none of the fields in these structs seem to be
endianness-annotated, but that there's a lot of cpu_to_be64 and so on
being used to frob values into them. Please make sure that the driver
passes a sparse check, which it looks like it almost certainly cannot
right now.

> +#define RING_DOORBELL(doorbell, QPID) { \
> + (writel(((1<<31) | (QPID)), doorbell)); \
> +}

Should probably be an inline function instead of a macro.

<b