public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: James Bottomley <James.Bottomley@SteelEye.com>
To: Randy Dunlap <randy.dunlap@oracle.com>
Cc: lkml <linux-kernel@vger.kernel.org>, zippel@linux-m68k.org
Subject: Re: how to handle indirect kconfig dependencies
Date: Mon, 20 Nov 2006 16:09:31 -0600	[thread overview]
Message-ID: <1164060571.2816.106.camel@mulgrave.il.steeleye.com> (raw)
In-Reply-To: <20061116200741.fb607fe4.randy.dunlap@oracle.com>

On Thu, 2006-11-16 at 20:07 -0800, Randy Dunlap wrote:
> Hi,
> 
> I have a (randconfig) build of 2.6.19-rc5-mm2 with:
> 
> CONFIG_DEBUG_READAHEAD=y
> 
> which selects DEBUG_FS, so DEBUG_FS=y, but DEBUG_FS depends on
> SYSFS, and SYSFS is not set in the randconfig.
> 
> This randconfig causes this build error:
> 
> fs/built-in.o: In function `debugfs_init':
> inode.c:(.init.text+0xdb2): undefined reference to `kernel_subsys'
> 
> so the question is:
> (How) can kconfig follow the dependency chain and either
> - prevent this odd config combination or
> - see that 'select DEBUG_FS' implies 'select SYSFS' and then enable SYSFS
> ?
> 
> I don't believe that the right answer is to add
> 	depends on SYSFS
> to DEBUG_READAHEAD.
> 
> 
> .config is at http://oss.oracle.com/~rdunlap/configs/config-readahead-debugfs

Actually, no, I don't think this is the right thing to do.  If we can't
persuade selected CONFIG options to give an inherited dependency to the
selectee, then the only other option is to make sure that selectable
config options have no dependencies (i.e. they select everything they
need).

James



  parent reply	other threads:[~2006-11-20 22:09 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-11-17  4:07 how to handle indirect kconfig dependencies Randy Dunlap
2006-11-17 13:55 ` Stefan Richter
2006-11-20 18:13   ` Adrian Bunk
2006-11-20 18:56     ` Stefan Richter
2006-11-20 22:09 ` James Bottomley [this message]
2006-11-26  3:46 ` Randy Dunlap

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1164060571.2816.106.camel@mulgrave.il.steeleye.com \
    --to=james.bottomley@steeleye.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=randy.dunlap@oracle.com \
    --cc=zippel@linux-m68k.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox