From: Nigel Cunningham <nigelc@bur.st>
To: "Rafael J. Wysocki" <rjw@sisk.pl>
Cc: David Chinner <dgc@sgi.com>, Andrew Morton <akpm@osdl.org>,
LKML <linux-kernel@vger.kernel.org>, Pavel Machek <pavel@ucw.cz>
Subject: Re: [PATCH -mm 0/2] Use freezeable workqueues to avoid suspend-related XFS corruptions
Date: Tue, 21 Nov 2006 09:39:50 +1100 [thread overview]
Message-ID: <1164062390.15714.5.camel@nigel.suspend2.net> (raw)
In-Reply-To: <1164061586.15714.1.camel@nigel.suspend2.net>
(Sorry to reply again)
On Tue, 2006-11-21 at 09:26 +1100, Nigel Cunningham wrote:
> Hi.
>
> On Mon, 2006-11-20 at 23:18 +0100, Rafael J. Wysocki wrote:
> > I think I/O can only be submitted from the process context. Thus if we freeze
> > all (and I mean _all_) threads that are used by filesystems, including worker
> > threads, we should effectively prevent fs-related I/O from being submitted
> > after tasks have been frozen.
>
> I know that will work. It's what I used to do before the switch to bdev
> freezing. I guess I need to look again at why I made the switch. Perhaps
> it was just because you guys gave freezing kthreads a bad wrap as too
> invasive or something. Bdev freezing is certainly fewer lines of code.
No, it looks like I wrongly believed that XFS was submitting I/O off a
timer, so that freezing kthreads wasn't enough. In that case, it looks
like freezing kthreads should be a good solution.
Regards,
Nigel
next prev parent reply other threads:[~2006-11-20 22:39 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-11-16 8:12 [PATCH -mm 0/2] Use freezeable workqueues to avoid suspend-related XFS corruptions Rafael J. Wysocki
2006-11-16 8:15 ` [PATCH -mm 1/2] Support for freezeable workqueues Rafael J. Wysocki
2006-11-16 15:03 ` Pavel Machek
2006-11-16 8:18 ` [PATCH -mm 2/2] Use freezeable workqueues in XFS Rafael J. Wysocki
2006-11-16 15:05 ` Pavel Machek
2006-11-17 0:50 ` [PATCH -mm 0/2] Use freezeable workqueues to avoid suspend-related XFS corruptions David Chinner
2006-11-17 15:14 ` Pavel Machek
2006-11-17 16:19 ` Rafael J. Wysocki
2006-11-20 0:15 ` David Chinner
2006-11-20 11:02 ` Nigel Cunningham
2006-11-20 20:40 ` Rafael J. Wysocki
2006-11-20 22:03 ` Nigel Cunningham
2006-11-20 22:18 ` Rafael J. Wysocki
2006-11-20 22:26 ` Nigel Cunningham
2006-11-20 22:39 ` Nigel Cunningham [this message]
2006-11-20 22:55 ` Rafael J. Wysocki
2006-11-21 0:51 ` Nigel Cunningham
2006-11-21 11:19 ` Rafael J. Wysocki
2006-11-21 4:20 ` David Chinner
2006-11-20 20:12 ` Rafael J. Wysocki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1164062390.15714.5.camel@nigel.suspend2.net \
--to=nigelc@bur.st \
--cc=akpm@osdl.org \
--cc=dgc@sgi.com \
--cc=linux-kernel@vger.kernel.org \
--cc=pavel@ucw.cz \
--cc=rjw@sisk.pl \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox