Re: [GFS2] Fix Kconfig wrt CRC32 [8/9]

[Steven Whitehouse <swhiteho@redhat.com>]

Hi,

On Fri, 2006-11-24 at 21:43 -0800, Randy Dunlap wrote:
> On Fri, 24 Nov 2006 09:34:49 +0000 Steven Whitehouse wrote:
> 
> > >From 6f788fd00c82533d4cd5587a9706f8468658a24d Mon Sep 17 00:00:00 2001
> > From: Steven Whitehouse <swhiteho@redhat.com>
> > Date: Mon, 20 Nov 2006 10:04:49 -0500
> > Subject: [PATCH] [GFS2] Fix Kconfig wrt CRC32
> > Content-Type: text/plain; charset=UTF-8
> > Content-Transfer-Encoding: 8bit
> > 
> > GFS2 requires the CRC32 library function. This was reported by
> > Toralf Förster.
> > 
> > Cc: Toralf Förster <toralf.foerster@gmx.de>
> > Signed-off-by: Steven Whitehouse <swhiteho@redhat.com>
> > ---
> >  fs/gfs2/Kconfig |    1 +
> >  1 files changed, 1 insertions(+), 0 deletions(-)
> > 
> > diff --git a/fs/gfs2/Kconfig b/fs/gfs2/Kconfig
> > index 8c27de8..c0791cb 100644
> > --- a/fs/gfs2/Kconfig
> > +++ b/fs/gfs2/Kconfig
> > @@ -2,6 +2,7 @@ config GFS2_FS
> >  	tristate "GFS2 file system support"
> >  	depends on EXPERIMENTAL
> >  	select FS_POSIX_ACL
> > +	select CRC32
> >  	help
> >  	A cluster filesystem.
> 
> Hi,
> 
> Do you also have Kconfig patches for DLM needing SYSFS
> and DLM needing CONFIG_NET ?
> 
> ---
> ~Randy

My original reply to this seemed to disappear into my email system
somewhere, so apologies if this is the second copy you get.

The DLM shouldn't depend upon SYSFS at all. I believe that its perfectly
ok whether or not thats compiled in. There is a patch relating to the
Kconfig for DLM which is in my -nmw tree:

http://www.kernel.org/git/?p=linux/kernel/git/steve/gfs2-2.6-nmw.git;a=commitdiff;h=8758fbc8724c2da8a6a062f2b61d79c8f2a55c5f

This applies after the patch adding the TCP communications layer to DLM
which is also in -nmw. The patches in -nmw (next merge window) are a
superset of the ones I just requested that Linus pull since it contains
the newer features and more involved bug fixes and clean ups.

I believe that the Kconfig in -nmw is correct for DLM, though I'm
willing to be proved wrong. I'm also copying in Patrick in case he wants
to comment further as its more his area than mine,

Steve.