From: Rohit Seth <rohitseth@google.com>
To: Andi Kleen <ak@suse.de>
Cc: Mel Gorman <mel@csn.ul.ie>, Andrew Morton <akpm@osdl.org>,
linux-kernel <linux-kernel@vger.kernel.org>,
David Rientjes <rientjes@cs.washington.edu>,
Paul Menage <menage@google.com>
Subject: Re: [Patch3/4]: fake numa for x86_64 patches
Date: Mon, 27 Nov 2006 09:59:08 -0800 [thread overview]
Message-ID: <1164650348.6619.12.camel@galaxy.corp.google.com> (raw)
In-Reply-To: <20061123090456.GD29738@bingen.suse.de>
On Thu, 2006-11-23 at 10:04 +0100, Andi Kleen wrote:
> On Wed, Nov 22, 2006 at 05:34:47PM -0800, Rohit Seth wrote:
> > Fix the existing numa=fake so that ioholes are appropriately configured.
> > Currently machines that have sizeable IO holes don't work with
> > numa=fake>4. This patch tries to equally partition the total available
> > memory in equal size chunk. The minimum size of the fake node is set to
> > 32MB.
>
> This patch seems to do far more than advertised in the change log?
>
> You're conflicting badly with Amul's numa hash function rewrite for example.
>
Both of these patches are mucking with hash function and
populate_memnodemap. I like Amul's approach of doing dynamic allocation
of numa hash map so that it can support >64GB of memory space. I will
resend the patches on top of his patch (incorporating your other
feedback).
-rohit
next prev parent reply other threads:[~2006-11-27 18:00 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-11-23 1:34 [Patch3/4]: fake numa for x86_64 patches Rohit Seth
2006-11-23 9:04 ` Andi Kleen
2006-11-27 17:59 ` Rohit Seth [this message]
2006-11-27 18:03 ` Andi Kleen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1164650348.6619.12.camel@galaxy.corp.google.com \
--to=rohitseth@google.com \
--cc=ak@suse.de \
--cc=akpm@osdl.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mel@csn.ul.ie \
--cc=menage@google.com \
--cc=rientjes@cs.washington.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox