public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Ben Collins <ben.collins@ubuntu.com>
To: Ingo Molnar <mingo@elte.hu>
Cc: Ben Collins <bcollins@ubuntu.com>,
	linux-kernel@vger.kernel.org, torvalds@osdl.org,
	Andrew Morton <akpm@osdl.org>
Subject: Re: [PATCH 2/4] [APIC] Allow disabling of UP APIC/IO-APIC by default, with command line option to turn it on.
Date: Fri, 01 Dec 2006 15:56:36 -0500	[thread overview]
Message-ID: <1165006596.5257.966.camel@gullible> (raw)
In-Reply-To: <20061201083900.GA26703@elte.hu>

On Fri, 2006-12-01 at 09:39 +0100, Ingo Molnar wrote:
> * Ben Collins <bcollins@ubuntu.com> wrote:

> that should be "ioapic", not "apic". The CPU has a piece of silicon 
> called the "local APIC" - enabled via the 'lapic' option, and disabled 
> via noapic. What the option above wants to enable is the IO-APIC in the 
> chipset (a different piece of silicon) and the interrupt routing 
> capabilities attached to it. That piece is what is causing the installer 
> problems.

I know the difference between APIC and IO-APIC :)

Thing is, the function right above the one I added was this:

static int __init parse_noapic(char *arg)
{
        /* disable IO-APIC */
        disable_ioapic_setup();
        return 0;
}
early_param("noapic", parse_noapic);

So while "ioapic" might make more sense, it's doesn't match the opposing
command line option of "noapic".

I could include this in the diff:

+/* "noapic" is for backward compatibility */
 early_param("noapic", parse_noapic);
+early_param("noioapic", parse_noapic);

And then add the "ioapic" option.

  reply	other threads:[~2006-12-01 20:56 UTC|newest]

Thread overview: 23+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-11-30  4:26 Ubuntu patch sync for 2.6.20 Ben Collins
2006-11-30  4:26 ` Ben Collins
2006-11-30  4:26 ` Ben Collins
2006-11-30  4:26 ` [PATCH 1/4] [x86] Add command line option to enable/disable hyper-threading Ben Collins
2006-11-30 11:06   ` Alan
2006-11-30 18:08     ` Siddha, Suresh B
2006-12-01 13:29   ` Pavel Machek
2006-12-01 13:41     ` Ben Collins
2006-12-01 14:32       ` Arjan van de Ven
2006-12-01 15:09         ` Ben Collins
2006-12-01 16:10           ` Arjan van de Ven
2006-12-01 16:14             ` Ben Collins
2006-12-01 16:20             ` Linus Torvalds
2006-12-01 16:56               ` Alan
2006-12-01 17:13                 ` Mark Rustad
2006-11-30  4:26 ` [PATCH 2/4] [APIC] Allow disabling of UP APIC/IO-APIC by default, with command line option to turn it on Ben Collins
2006-12-01  8:39   ` Ingo Molnar
2006-12-01 20:56     ` Ben Collins [this message]
2006-12-02  8:56       ` Ingo Molnar
2006-11-30  4:26 ` [PATCH 3/4] [ATM] Add CPPFLAGS to byteorder.h check Ben Collins
2006-11-30  4:26 ` [PATCH 4/4] [HVCS] Select HVC_CONSOLE if HVCS is enabled Ben Collins
2006-11-30 12:32   ` Roman Zippel
2006-11-30 15:04     ` Ben Collins

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1165006596.5257.966.camel@gullible \
    --to=ben.collins@ubuntu.com \
    --cc=akpm@osdl.org \
    --cc=bcollins@ubuntu.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@elte.hu \
    --cc=torvalds@osdl.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox