Re: [PATCH 32/36] driver core: Introduce device_move(): move a device to a new parent.

Greg KH
2006-12-04T19:59:16Z

On Sun, Dec 03, 2006 at 05:26:03PM +0100, Marcel Holtmann wrote:
> Hi Greg,
>
> > Provide a function device_move() to move a device to a new parent device. Add
> > auxilliary functions kobject_move() and sysfs_move_dir().
> > kobject_move() generates a new uevent of type KOBJ_MOVE, containing the
> > previous path (DEVPATH_OLD) in addition to the usual values. For this, a new
> > interface kobject_uevent_env() is created that allows to add further
> > environmental data to the uevent at the kobject layer.
>
> has this one been tested? I don't get it working. I always get an EINVAL
> when trying to move the TTY device of a Bluetooth RFCOMM link around.

I relied on Cornelia to test this. I think some s390 patches depend on
this change, right?

> And shouldn't device_move(dev, NULL) re-attach it to the virtual device
> tree instead of failing?

Yes, that would be good to have.

thanks,

greg k-h