public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Thomas Gleixner <tglx@linutronix.de>
To: Al Viro <viro@ftp.linux.org.uk>
Cc: Linus Torvalds <torvalds@osdl.org>,
	linux-arch@vger.kernel.org, linux-kernel@vger.kernel.org,
	gcc@gcc.gnu.org
Subject: Re: [RFC] timers, pointers to functions and type safety
Date: Sat, 02 Dec 2006 13:59:30 +0100	[thread overview]
Message-ID: <1165064370.24604.36.camel@localhost.localdomain> (raw)
In-Reply-To: <20061201172149.GC3078@ftp.linux.org.uk>

On Fri, 2006-12-01 at 17:21 +0000, Al Viro wrote:
> Now, there's another question: how do we get there?  Or, at least, from
> current void (*)(unsigned long) to void (*)(void *)...

I think the real solution should be 

	void (*function)(struct timer_list *timer);

and hand the timer itself to the callback. Most of the timers are
embedded into data structures anyway and for the rest we can easily
build one.

> "A fscking huge patch flipping everything at once" is obviously not an
> answer; too much PITA merging and impossible to review.

There are ~ 500 files affected and this is in the range of cleanups we
did recently at the end of the merge window already. I'd volunteer to
hack this up and keep the patch up to date until the final merge. I have
done that before and I'm not scared about it. The patches are a couple
of lines per file and I do not agree that this is impossible to review. 

	tglx



  parent reply	other threads:[~2006-12-02 12:56 UTC|newest]

Thread overview: 39+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-12-01 17:21 [RFC] timers, pointers to functions and type safety Al Viro
2006-12-02  6:29 ` Daniel Berlin
2006-12-02 12:36   ` Al Viro
2006-12-02  9:23 ` Kyle Moffett
2006-12-02 12:42   ` Al Viro
2006-12-02 20:53     ` Kyle Moffett
2006-12-02 10:47 ` Arnd Bergmann
2006-12-02 12:59 ` Thomas Gleixner [this message]
2006-12-02 14:05   ` Al Viro
2006-12-02 14:45     ` Thomas Gleixner
2006-12-02 16:02       ` Matthew Wilcox
2006-12-02 18:06         ` Thomas Gleixner
2006-12-02 18:19           ` Al Viro
2006-12-02 18:27             ` Thomas Gleixner
2006-12-02 18:40               ` Al Viro
2006-12-02 18:48                 ` Al Viro
2006-12-02 21:43                 ` Roman Zippel
2006-12-02 21:59                   ` Al Viro
2006-12-02 22:13                     ` Roman Zippel
2006-12-02 22:40                       ` Al Viro
2006-12-02 23:06                         ` Roman Zippel
2006-12-03 10:21                           ` Pavel Machek
2006-12-03 11:27                             ` Russell King
2006-12-03 15:21                               ` Roman Zippel
2006-12-03 21:01                                 ` Pavel Machek
2006-12-03 22:52                                   ` Roman Zippel
2006-12-03 23:15                                     ` Pavel Machek
2006-12-04 11:14                               ` David Howells
2006-12-04 12:16                                 ` Russell King
2006-12-04 13:03                                   ` David Howells
2006-12-04 13:29                                     ` Russell King
2006-12-04 14:17                                       ` David Howells
2006-12-04 14:22                                         ` Russell King
2006-12-04 11:48             ` Ingo Molnar
2006-12-04 12:22               ` David Howells
2006-12-06  0:24                 ` Al Viro
2006-12-06 10:20                   ` David Howells
2006-12-12  9:59                   ` Ingo Molnar
2006-12-02 21:32         ` Roman Zippel

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1165064370.24604.36.camel@localhost.localdomain \
    --to=tglx@linutronix.de \
    --cc=gcc@gcc.gnu.org \
    --cc=linux-arch@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=torvalds@osdl.org \
    --cc=viro@ftp.linux.org.uk \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox