Re: [PATCH] VIA and SiS AGP chipsets are x86-only

Randy Dunlap
2006-12-05T23:06:06Z

On Tue, 05 Dec 2006 14:56:41 -0800 Ian Romanick wrote:

> -----BEGIN PGP SIGNED MESSAGE-----
> Hash: SHA1
>
> Matthew Wilcox wrote:
> > There's no point in troubling the Alpha, IA-64, PowerPC and PARISC
> > people with SiS and VIA options. Andrew thinks it helps find bugs,
> > but there's no evidence of that.
> >
> > Signed-off-by: Matthew Wilcox <matthew@wil.cx>
> >
> > diff --git a/drivers/char/agp/Kconfig b/drivers/char/agp/Kconfig
> > index c603bf2..a9f9c48 100644
> > --- a/drivers/char/agp/Kconfig
> > +++ b/drivers/char/agp/Kconfig
> > @@ -86,7 +86,7 @@ config AGP_NVIDIA
> >
> > config AGP_SIS
> > tristate "SiS chipset support"
> > - depends on AGP
> > + depends on AGP && X86
> > help
> > This option gives you AGP support for the GLX component of
> > X on Silicon Integrated Systems [SiS] chipsets.
> > @@ -103,7 +103,7 @@ config AGP_SWORKS
> >
> > config AGP_VIA
> > tristate "VIA chipset support"
> > - depends on AGP
> > + depends on AGP && X86
> > help
> > This option gives you AGP support for the GLX component of
> > X on VIA MVP3/Apollo Pro chipsets.
>
> I don't know about SiS, but this is certainly *not* true for Via. There
> are some PowerPC and, IIRC, Alpha motherboards that have Via chipsets.
> My config-fu isn't quite what it should be, so this may be a dumb
> question. Does the "& X86" requirement exclude x86-64?

No, X86 includes both X86_32 and X86_64.

---
~Randy