From: Benjamin Herrenschmidt <benh@kernel.crashing.org>
To: Jean Delvare <khali@linux-fr.org>
Cc: Andrew Morton <akpm@osdl.org>, Paul Mackerras <paulus@samba.org>,
Linux Kernel list <linux-kernel@vger.kernel.org>
Subject: sysfs file creation result nightmare (WAS radeonfb: Fix sysfs_create_bin_file warnings)
Date: Sun, 10 Dec 2006 06:59:10 +1100 [thread overview]
Message-ID: <1165694351.1103.133.camel@localhost.localdomain> (raw)
In-Reply-To: <20061209165606.2f026a6c.khali@linux-fr.org>
On Sat, 2006-12-09 at 16:56 +0100, Jean Delvare wrote:
> Check for error on radeonfb device sysfs files creation. This fixes the
> following warnings:
(Moving to LKML as I think that's a generic issue)
As usual with most of that crap about return values from
sysfs_create_file, I disagree. strongly.
Why would I prevent the framebuffer from initializing (and thus a
console to be displayed at all on many machines) just because for some
reason, I couldn't create a pair of EDID files in sysfs that are not
even very useful anymore ?
I have _plenty_ of cases where the failure to create sysfs files, while
annoying and maybe deserving a warning, certainly doesn't imply
completely preventing the driver from initializing. However, all the
patches I've seen so far to fix the new warnings do just that (make the
driver fail)
I'd really like to have some kind of macro or attribute or whatever I
can put on a function call to say that I'm purposefully ignoring the
error. Is there some gcc magic that can do that ?
Ben.
next parent reply other threads:[~2006-12-09 19:59 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20061209165606.2f026a6c.khali@linux-fr.org>
2006-12-09 19:59 ` Benjamin Herrenschmidt [this message]
2006-12-09 20:22 ` sysfs file creation result nightmare (WAS radeonfb: Fix sysfs_create_bin_file warnings) Muli Ben-Yehuda
2006-12-09 20:53 ` Benjamin Herrenschmidt
2006-12-09 20:38 ` Andrew Morton
2006-12-09 20:55 ` Benjamin Herrenschmidt
2006-12-09 21:44 ` Olivier Galibert
2006-12-09 21:58 ` Andrew Morton
2006-12-09 22:34 ` Olivier Galibert
2006-12-09 22:53 ` Andrew Morton
2006-12-10 0:55 ` Benjamin Herrenschmidt
2006-12-15 14:47 ` sysfs file creation result nightmare Jean Delvare
2006-12-15 20:16 ` Benjamin Herrenschmidt
2006-12-15 20:31 ` Andrew Morton
2006-12-20 8:01 ` Greg KH
2006-12-20 9:27 ` Benjamin Herrenschmidt
2006-12-11 2:46 ` sysfs file creation result nightmare (WAS radeonfb: Fix sysfs_create_bin_file warnings) Paul Mackerras
2006-12-14 21:42 ` Bill Davidsen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1165694351.1103.133.camel@localhost.localdomain \
--to=benh@kernel.crashing.org \
--cc=akpm@osdl.org \
--cc=khali@linux-fr.org \
--cc=linux-kernel@vger.kernel.org \
--cc=paulus@samba.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox