From: Benjamin Herrenschmidt <benh@kernel.crashing.org>
To: Andrew Morton <akpm@osdl.org>
Cc: Olivier Galibert <galibert@pobox.com>,
Jean Delvare <khali@linux-fr.org>,
Paul Mackerras <paulus@samba.org>,
Linux Kernel list <linux-kernel@vger.kernel.org>
Subject: Re: sysfs file creation result nightmare (WAS radeonfb: Fix sysfs_create_bin_file warnings)
Date: Sun, 10 Dec 2006 11:55:31 +1100 [thread overview]
Message-ID: <1165712131.1103.166.camel@localhost.localdomain> (raw)
In-Reply-To: <20061209145303.3d5fe141.akpm@osdl.org>
> And (ultimately) make the function return void.
>
> Yes, that's probably a valid approach - we've discussed it before but nobody has
> taken it further.
I would have preferred that approach (with a WARN_ON rather than a BUG
though). On the other hand that would make it slightly harder for the
few cases (if any ?) who actually want something like a "create if it
doesn't exist already" semantic.
I'm a bit worried by the amount of code added by systematic checking of
the results for cases that really should never happen. That's why I
prefer a BUG/WARN type semantic.
Maybe the best is to have the examples like radeonfb actually do the
WARN_ON(sysfs_create_file(...));
Ben.
next prev parent reply other threads:[~2006-12-10 0:55 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20061209165606.2f026a6c.khali@linux-fr.org>
2006-12-09 19:59 ` sysfs file creation result nightmare (WAS radeonfb: Fix sysfs_create_bin_file warnings) Benjamin Herrenschmidt
2006-12-09 20:22 ` Muli Ben-Yehuda
2006-12-09 20:53 ` Benjamin Herrenschmidt
2006-12-09 20:38 ` Andrew Morton
2006-12-09 20:55 ` Benjamin Herrenschmidt
2006-12-09 21:44 ` Olivier Galibert
2006-12-09 21:58 ` Andrew Morton
2006-12-09 22:34 ` Olivier Galibert
2006-12-09 22:53 ` Andrew Morton
2006-12-10 0:55 ` Benjamin Herrenschmidt [this message]
2006-12-15 14:47 ` sysfs file creation result nightmare Jean Delvare
2006-12-15 20:16 ` Benjamin Herrenschmidt
2006-12-15 20:31 ` Andrew Morton
2006-12-20 8:01 ` Greg KH
2006-12-20 9:27 ` Benjamin Herrenschmidt
2006-12-11 2:46 ` sysfs file creation result nightmare (WAS radeonfb: Fix sysfs_create_bin_file warnings) Paul Mackerras
2006-12-14 21:42 ` Bill Davidsen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1165712131.1103.166.camel@localhost.localdomain \
--to=benh@kernel.crashing.org \
--cc=akpm@osdl.org \
--cc=galibert@pobox.com \
--cc=khali@linux-fr.org \
--cc=linux-kernel@vger.kernel.org \
--cc=paulus@samba.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox