From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S936875AbWLKQFZ (ORCPT ); Mon, 11 Dec 2006 11:05:25 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S936924AbWLKQFZ (ORCPT ); Mon, 11 Dec 2006 11:05:25 -0500 Received: from gateway-1237.mvista.com ([63.81.120.158]:44569 "EHLO gateway-1237.mvista.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S936875AbWLKQFZ (ORCPT ); Mon, 11 Dec 2006 11:05:25 -0500 Subject: Re: [PATCH -rt][RESEND] spin lock imbalance in ibm emac From: Daniel Walker To: Ingo Molnar Cc: linux-kernel@vger.kernel.org In-Reply-To: <20061211155908.GA31944@elte.hu> References: <20061210163848.101585000@mvista.com> <20061211092759.GA23041@elte.hu> <1165851624.7764.3.camel@imap.mvista.com> <20061211155908.GA31944@elte.hu> Content-Type: text/plain Date: Mon, 11 Dec 2006 08:05:17 -0800 Message-Id: <1165853117.7764.5.camel@imap.mvista.com> Mime-Version: 1.0 X-Mailer: Evolution 2.6.3 (2.6.3-1.fc5.5) Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 2006-12-11 at 16:59 +0100, Ingo Molnar wrote: > * Daniel Walker wrote: > > > On Mon, 2006-12-11 at 10:27 +0100, Ingo Molnar wrote: > > > * Daniel Walker wrote: > > > > > > > Sent this a long time ago, still exists. > > > > > > > > Signed-Off-By: Daniel Walker > > > > > > hm, what does this do, and why isnt it upstream? > > > > AFAIK, those locks are added in -rt . I'm not sure how they got in > > there, but they fix that driver when running in a thread. The driver > > has unsafe SMP locking, but the only system it runs on (PPC4xx) is > > uniprocessor. So it's not broken upstream per se. > > ok, i've applied your patch. What about the OMAP fix? that one's been sitting around for a while too. Daniel