kernel/hrtimer.c(511): remark #593: variable "base" was set but never used

kernel/hrtimer.c(511): remark #593: variable "base" was set but never used

[d binderman]

Hello there,

I just tried to compile Linux kernel 2.6.18.3 with the Intel C
C compiler.

The compiler said

kernel/hrtimer.c(511): remark #593: variable "base" was set but never used

The source code is

    struct hrtimer_base *base;

I have checked the source code and I agree with the compiler.
Suggest delete local variable.

Regards

David Binderman

_________________________________________________________________
Be the first to hear what's new at MSN - sign up to our free newsletters! 
http://www.msn.co.uk/newsletters

[PATCH] hrtimer: remove unused variable

[David Rientjes]

Remove unused 'base' variable.

Cc: Thomas Gleixner <tglx@linutronix.de>
Signed-off-by: David Rientjes <rientjes@cs.washington.edu>
---
 kernel/hrtimer.c |    3 +--
 1 files changed, 1 insertions(+), 2 deletions(-)

diff --git a/kernel/hrtimer.c b/kernel/hrtimer.c
index d0ba190..b55532f 100644
--- a/kernel/hrtimer.c
+++ b/kernel/hrtimer.c
@@ -508,11 +508,10 @@ EXPORT_SYMBOL_GPL(hrtimer_cancel);
  */
 ktime_t hrtimer_get_remaining(const struct hrtimer *timer)
 {
-	struct hrtimer_base *base;
 	unsigned long flags;
 	ktime_t rem;
 
-	base = lock_hrtimer_base(timer, &flags);
+	lock_hrtimer_base(timer, &flags);
 	rem = ktime_sub(timer->expires, timer->base->get_time());
 	unlock_hrtimer_base(timer, &flags);
 

Re: [PATCH] hrtimer: remove unused variable

[Steven Rostedt]

On Thu, 2006-11-23 at 02:33 -0800, David Rientjes wrote:
> Remove unused 'base' variable.
> 

Or just use it.

Signed-off-by: Steven Rostedt <rostedt@goodmis.org>

Index: linux-2.6.19/kernel/hrtimer.c
===================================================================
--- linux-2.6.19.orig/kernel/hrtimer.c	2006-12-12 16:36:09.000000000 -0500
+++ linux-2.6.19/kernel/hrtimer.c	2006-12-12 16:36:36.000000000 -0500
@@ -513,7 +513,7 @@ ktime_t hrtimer_get_remaining(const stru
 	ktime_t rem;
 
 	base = lock_hrtimer_base(timer, &flags);
-	rem = ktime_sub(timer->expires, timer->base->get_time());
+	rem = ktime_sub(timer->expires, base->get_time());
 	unlock_hrtimer_base(timer, &flags);
 
 	return rem;