From: jamal <hadi@cyberus.ca>
To: Ingo Molnar <mingo@elte.hu>
Cc: "David S. Miller" <davem@davemloft.net>,
linux-kernel@vger.kernel.org, Andrew Morton <akpm@osdl.org>,
Linus Torvalds <torvalds@osdl.org>,
dwmw2@infradead.org, Joy Latten <latten@austin.ibm.com>
Subject: Re: [patch] net/xfrm: fix crash in ipsec audit logging
Date: Tue, 26 Dec 2006 13:37:32 -0500 [thread overview]
Message-ID: <1167158252.3746.4.camel@localhost> (raw)
In-Reply-To: <20061226175619.GA27982@elte.hu>
On Tue, 2006-26-12 at 18:56 +0100, Ingo Molnar wrote:
> + xfrm_audit_log(NETLINK_CB(skb).loginuid, NETLINK_CB(skb).sid,
> + AUDIT_MAC_IPSEC_DELSPD, delete, xp, NULL);
> +
> if (!delete) {
> struct sk_buff *resp_skb;
You could move the call into the else from above if (!delete) maybe?
Otherwise you have to add back the "if (delete)" check since that
function could be used to either retrieve (which is not subject to an
audit) or delete an xp.
cheers,
jamal
next prev parent reply other threads:[~2006-12-26 18:37 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-12-26 17:56 [patch] net/xfrm: fix crash in ipsec audit logging Ingo Molnar
2006-12-26 18:37 ` jamal [this message]
-- strict thread matches above, loose matches on Subject: below --
2007-01-02 20:57 Joy Latten
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1167158252.3746.4.camel@localhost \
--to=hadi@cyberus.ca \
--cc=akpm@osdl.org \
--cc=davem@davemloft.net \
--cc=dwmw2@infradead.org \
--cc=latten@austin.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=torvalds@osdl.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox