From: Daniel Walker <dwalker@mvista.com>
To: Randy Dunlap <rdunlap@xenotime.net>
Cc: Fengguang Wu <fengguang.wu@gmail.com>,
Hua Zhong <hzhong@gmail.com>, Andrew Morton <akpm@osdl.org>,
LKML <linux-kernel@vger.kernel.org>,
mingo@elte.hu, johnstul@us.ibm.com
Subject: Re: [BUG 2.6.20-rc2-mm1] init segfaults when CONFIG_PROFILE_LIKELY=y
Date: Sun, 31 Dec 2006 13:11:26 -0800 [thread overview]
Message-ID: <1167599486.14081.89.camel@imap.mvista.com> (raw)
In-Reply-To: <20061231124358.3b0837c2.rdunlap@xenotime.net>
On Sun, 2006-12-31 at 12:43 -0800, Randy Dunlap wrote:
> On Sun, 31 Dec 2006 11:45:09 -0800 Daniel Walker wrote:
>
> > On Sun, 2006-12-31 at 23:04 +0800, Fengguang Wu wrote:
> > > Hi,
> > >
> > > The following messages keeps popping up when CONFIG_PROFILE_LIKELY=y:
> > >
> > > init[1]: segfault at ffffffff8118c110 rip ffffffff8118c110 rsp 00007fff9a9d14d8 error 15
> > > init[1]: segfault at ffffffff8118c110 rip ffffffff8118c110 rsp 00007fff9a9d14d8 error 15
> > > init[1]: segfault at ffffffff8118c110 rip ffffffff8118c110 rsp 00007fff9a9d14d8 error 15
> > > init[1]: segfault at ffffffff8118c110 rip ffffffff8118c110 rsp 00007fff9a9d14d8 error 15
> > > init[1]: segfault at ffffffff8118c110 rip ffffffff8118c110 rsp 00007fff9a9d14d8 error 15
> > > init[1]: segfault at ffffffff8118c110 rip ffffffff8118c110 rsp 00007fff9a9d14d8 error 15
> > > init[1]: segfault at ffffffff8118c110 rip ffffffff8118c110 rsp 00007fff9a9d14d8 error 15
> > > init[1]: segfault at ffffffff8118c110 rip ffffffff8118c110 rsp 00007fff9a9d14d8 error 15
> > >
> >
> >
> > Does this seem like an appropriate solution? This just reconstitutes
> > Ingo's patch by removing the unlikely calls that got added recently.
>
> How does this fix the problem? (if it does)
> What is the real cause of the problem?
Well I tested it so I sure hope it fixes it (unless I've gone mad). I
guess we can wait for Fengguang to test it tho.
> > Maybe a comment into vsyscall.c that says to stay away from all macro's
> > and possible debug code that could be added might be helpful ?
>
> Why?
I don't know very much about vsyscalls, but from what I've read they
actually reside in userspace. So with and "unlikely" added into that
code, and profiling on, you will end up calling do_check_likely() which
is in kernel space that's how the segfault happens.
I imagine this goes for all debugging in kernel space, you can't add it
into a vsyscall. That's my reasoning behind adding a comment.
Daniel
next prev parent reply other threads:[~2006-12-31 21:12 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20061231150422.GA5285@mail.ustc.edu.cn>
2006-12-31 15:04 ` [BUG 2.6.20-rc2-mm1] init segfaults when CONFIG_PROFILE_LIKELY=y Fengguang Wu
2006-12-31 19:45 ` Daniel Walker
2006-12-31 20:43 ` Randy Dunlap
2006-12-31 21:11 ` Daniel Walker [this message]
2006-12-31 23:12 ` Randy Dunlap
[not found] ` <20070101024029.GA6249@mail.ustc.edu.cn>
2007-01-01 2:40 ` Fengguang Wu
2007-01-02 19:47 ` john stultz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1167599486.14081.89.camel@imap.mvista.com \
--to=dwalker@mvista.com \
--cc=akpm@osdl.org \
--cc=fengguang.wu@gmail.com \
--cc=hzhong@gmail.com \
--cc=johnstul@us.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=rdunlap@xenotime.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox