public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Lee Schermerhorn <Lee.Schermerhorn@hp.com>
To: Andrew Morton <akpm@osdl.org>,
	linux-kernel <linux-kernel@vger.kernel.org>
Cc: sam@ravnborg.org
Subject: 2.6.20-rc2-mm1:  Makefile drops local version when checking headers
Date: Tue, 02 Jan 2007 11:23:35 -0500	[thread overview]
Message-ID: <1167755015.5104.2.camel@localhost> (raw)

When building 2.6.20-rc2-mm1 with CHECK_HEADERS=y, the Makefile will
build the target "include/config/kernel.release" twice.  The first time,
the CONFIG_LOCALVERSION [and any auto local version] will correctly be
appended.  Then, when it builds the "headers_check" target, the Makefile
will build the "include/config/kernel.release" target again, dropping
the local version information.  If you then do a "make
[modules_]install" in this tree, the install will use the second version
string w/o the localversion, installing modules in the wrong place and
kernel/initrd with wrong name, possibly overwriting desired copies of
the "2.6.20-rc2-mm1" kernel/modules.

[Aside:  it also appears that several items, including the kernel
itself, get rebuilt during "make [modules_]install" after a successful
"make [all]".  I think this is new behavior.]

This behavior appears to have been introduced by the patch:

build-compileh-earlier.patch

Sorry, no patch to propose.  Simple workaround is just to omit header
checks.

Here's the results of some instrumentation that I added to the Makefile
showing the sequence of targets built and which dependents cause the
build:

-------------------
<first build of target OK>

generating include/config/kernel.release:  2.6.20-rc1-mm1+foo
	KERNELVERSION = 2.6.20-rc1-mm1
	localver-full = +foo
 		localver      = +foo
		localver-auto = 
Target:  include/linux/utsrelease.h
Target:  prepare3
Target:  prepare1

<but later, for headers check>

generating include/config/kernel.release:  2.6.20-rc1-mm1
	KERNELVERSION = 2.6.20-rc1-mm1
	localver-full = 
 		localver      = 
		localver-auto = 
Target:  include/linux/utsrelease.h
Target:  headers_install
Target:  headers_check
----------------------------

Regards,
Lee


             reply	other threads:[~2007-01-02 16:37 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-01-02 16:23 Lee Schermerhorn [this message]
2007-01-02 21:59 ` 2.6.20-rc2-mm1: Makefile drops local version when checking headers Sam Ravnborg

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1167755015.5104.2.camel@localhost \
    --to=lee.schermerhorn@hp.com \
    --cc=akpm@osdl.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=sam@ravnborg.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox